Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template review #1000

Closed
robocoder opened this issue Oct 9, 2009 · 3 comments
Closed

Template review #1000

robocoder opened this issue Oct 9, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
0.5

Comments

@robocoder
Copy link
Contributor

For consistency:

  • in plugins/* and themes/default, .tpl files should be in templates sub-folder
  • review separation of business logic vs presentation (Installation SystemCheck comes to mind)
@robocoder
Copy link
Contributor Author

Decided not to touch core/Tracker/javascriptTag.tpl (not processed by Smarty) or themes/default/*.tpl until we have a better idea of how these fit in with UI skins/themes.

@robocoder
Copy link
Contributor Author

files with embedded styles:

  • ./API/templates/listAllAPI.tpl
  • ./CoreHome/templates/cloud.tpl
  • ./Feedback/templates/index.tpl
  • ./Feedback/templates/sent.tpl
  • ./Goals/templates/form_add_goal.tpl
  • ./Goals/templates/single_goal.tpl
  • ./Installation/templates/displayJavascriptCode.tpl
  • ./Installation/templates/structure.tpl
  • ./Installation/templates/systemCheck.tpl
  • ./Live/templates/index.tpl
  • ./SitesManager/templates/DisplayJavascriptCode.tpl
  • ./SitesManager/templates/SitesManager.tpl
  • ./UsersManager/templates/UsersManager.tpl
  • ./Widgetize/templates/index.tpl

files with embedded scripts:

  • ./CoreAdminHome/templates/header.tpl
  • ./CoreHome/templates/datatable_actions_js.tpl
  • ./CoreHome/templates/datatable_js.tpl
  • ./CoreHome/templates/js_css_includes.tpl
  • ./CoreHome/templates/js_global_variables.tpl
  • ./CoreHome/templates/period_select.tpl
  • ./CoreHome/templates/piwik_tag.tpl
  • ./CoreHome/templates/sites_selection.tpl
  • ./CoreUpdater/templates/header.tpl
  • ./Dashboard/templates/index.tpl
  • ./ExampleFeedburner/templates/feedburner.tpl
  • ./GeoIP/templates/index.tpl
  • ./Goals/templates/add_edit_goal.tpl
  • ./Goals/templates/single_goal.tpl
  • ./Goals/templates/title_and_evolution_graph.tpl
  • ./Installation/templates/displayJavascriptCode.tpl
  • ./Installation/templates/structure.tpl
  • ./Installation/templates/tablesCreation.tpl
  • ./LanguagesManager/templates/languages.tpl
  • ./Live/templates/index.tpl
  • ./Login/templates/header.tpl
  • ./Referers/templates/index.tpl
  • ./SitesManager/templates/SitesManager.tpl
  • ./UserCountry/templates/index.tpl
  • ./UsersManager/templates/UsersManager.tpl
  • ./VisitFrequency/templates/index.tpl
  • ./VisitsSummary/templates/index.tpl
  • ./Widgetize/templates/index.tpl
  • ./Widgetize/templates/test_jsinclude2.tpl
  • ./Widgetize/templates/test_jsinclude.tpl

@robocoder
Copy link
Contributor Author

We'll tackle the embedded style issues during the css cleanup.

@robocoder robocoder added this to the Piwik 0.5 milestone Jul 8, 2014
@mattab mattab added the wontfix label Aug 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@mattab @robocoder