New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty translations string should default to english (Catalan translation is partially broken) #1003
Comments
latest rev in svn worksforme. matt: can you svn up piwik.org/demo-trunk ? |
I updated demo-trunk and is broken too (look at Referers>Overview which doesn't load) Note: we should update unit test to detect this broken use case. |
In [1493], Add missing widget category name. |
I think the proper fix is to eliminate the translation of the widget category name in Piwik_Add():
because many of the widget category names are neither translated nor translateable:
|
scratch that... I forgot category names are used in Widgetize. |
p.s. to explain the bug/fix: because the translated string was "", json_encode (on piwik.org) discarded the UserSettings widgets when serializing. On my server, json_encode used "" for the widget category name. |
In [1495], refs #1003; use translation strings for consistency |
The translation manager should have used the english translation if the original translation string was "empty" - does your comment mean that this is not working as expected? |
The translation manager uses the English string if the translation string is not defined (see array_merge). In the Catalan translation, it was defined as an empty string. |
reopening it's a quick fix |
In [1501], fixes #1003 - filter empty translations |
From email:
If you go to piwik online demo and choose catalan language, piwik does not work correctly. Try to go , for exemple, to "referers" tab... You cannot.
I think the translation is bad-formed, I think some errors like characters like which are escaped ç , and that's because it doesn't work.
The text was updated successfully, but these errors were encountered: