New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export as image via server-side proxy #1014
Comments
Attachment: Screenshots |
Unless this is IE8, this feature is not available on earlier versions of Internet Explorer (i.e., lack support for data: pseudo-protocol). |
Just got pinged on this. An alternative might be to somehow POST the data back to the server and have the server generate a regular image in response. e.g.,
Care needed to avoid introducing any security vulnerabilities, e.g., arbitrary file upload & execution, XSS reflection, etc. |
It looks like greg already implemented this for UserCountryMap. We should be able to refactor this and make it available to the OFC charts as well. |
I'm thinking of putting all the proxy stuff into its own module, eg Piwik_Proxy
Can I move the misc/redirectUrl code here too? |
Better yet, move to the CoreTheme plugin. |
Piwik_Proxy sounds good ; not sure about CoreTheme plugin, as this code would be shared by all themes? I still have to review your proposal about theming, will do in the next few days :) |
Attachment: Proxy plugin |
We can either have Piwik_CoreHome_Controller extend Piwik_Proxy_Controller, or change the URLs to use module=Proxy. (Ditto for UserCountryMap.) |
By changing URLs, do you mean just the 'export as image' URLs and/or the getCSS/getJS? I think it would make sense...? |
Both. |
(In [3175]) refs #1014 - move getCss, getJs, getHtc, and redirect to Proxy plugin; todo: exportImage (requires a change to open-flash-chart.swf and common.js) |
(In [3190]) refs #1014 |
(In [3271]) refs #1014 |
Export as image works for me in dashboard and Visitors>Overview on FF and IE8 - should this bug be closed? |
(In [3349]) refs #1014 - split UserCountryMap Controller into a separate file and call proxy methods for "export as image" |
Closing for now... the change to common.js is more involved. |
(In [3350]) refs #1014 - rename methods |
The export as image functionality does not work, at least not for the section Visitors - Overview - Evolution over the last days. The results is shown in attached document.
The text was updated successfully, but these errors were encountered: