Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sub table always loads data for the right row when date=Today #1024

Open
robocoder opened this issue Oct 29, 2009 · 6 comments
Open

Make Sub table always loads data for the right row when date=Today #1024

robocoder opened this issue Oct 29, 2009 · 6 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@robocoder
Copy link
Contributor

This error occurred in the svn trunk (rev 1547) in my test environment.

Test procedure:

  • create a new directory
  • add a page with the tracking code
  • visit page (i.e., first visit ever for this directory & page, and also the first visit of the day)
  • go to Actions | Pages
  • click on a page URL (+ new_directory) to open the subtable
  • observation: Piwik appeared to hang ("loading")
  • refresh page whereupon Piwik promptly displayed the subtable

This is the error (and typo) in the log:

You are requesting a precise subTable but there is not such data in the Archive.
@robocoder
Copy link
Contributor Author

Of course, once I cleared the cache, dropped the archives, and truncated the log_ tables, I can't reproduce the above...

@robocoder
Copy link
Contributor Author

For future reference:

GET /index.php?filter_offset=0&module=Actions&action=getPageUrlsSubDataTable&idSite=1&period=day&date=2009-10-29&enable_sort=false&filter_sort_column=nb_visits&filter_sort_order=desc&filter_limit=100&search_recursive=1&viewDataTable=table&controllerActionCalledWhenRequestSubTable=getPageUrlsSubDataTable&totalRows=1&enable_filter_excludelowpop=0&idSubtable=1

@mattab
Copy link
Member

mattab commented Jul 29, 2010

This was probably caused in the following case

  • default Piwik: real time process every 10 seconds
  • Look at reports, they are processed.
  • more than 10 seconds later, you click on the row with a given ID
  • Piwik re-processes stats for today. The ID you clicked earlier now matches to something different (loads a subtable that doesn't match), or will not load anything.

I don't think any trivial fix for this one.
A solution could be to have a click pass the label of the row, and then use the label to search for the matching parent row, to fetch the subtable. This is not trivial and could lead to some issues.

@robocoder
Copy link
Contributor Author

Could we we pass the label of the row, and if it doesn't match on the server side, we refresh the whole table and expand that row?

@anonymous-matomo-user
Copy link

This happens to me all the time with Piwik 1.0 and is a major annoyance. I use piwik with "today" as the default displayed day and track referrers in real time, but expanding any row fails to give the proper result once every other try or so.

A solution for this, as vipsoft suggested, would be to add more sanity checks whenever expanding a row. Matching on label as well as id would be a good start. One could even imagine searching for the proper id if the labels don't match, instead of relying on the id itself.

@mattab
Copy link
Member

mattab commented Feb 6, 2014

Maybe a solution would be to not trigger a re-archiving when requesting a sub-table, and use the existing pre-processed archive if found? This would be an elegant fix it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants