Opened 4 years ago

Closed 4 years ago

#1029 closed Bug (fixed)

Replace thickbox 3.1

Reported by: vipsoft Owned by:
Priority: low Milestone: Piwik 0.5
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

Issues:

  • FF3/Safari: feedback form; scrollbar(s) appear; worse in FF3 because submit button is obscured
  • ThickBox 3.1 is no longer maintained

Proposal:

  • replace thickbox with jquery-ui dialog.

Reference:

Attachments (1)

piwik-dialog.patch (20.0 KB) - added by pebosi 4 years ago.
Please review and try my patch to replace thickbox with jquery ui dialoh

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by pebosi

Please review and try my patch to replace thickbox with jquery ui dialoh

comment:1 Changed 4 years ago by pebosi

patch added.

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

In [1614], fixes #1029 - replace obsolete/unsupported thickbox with jqueryui dialog

Thanks pebosi!

Minor changes to patch to only add the iframe once and handle case where the Feedback plugin is disabled.

Note: See TracTickets for help on using tickets.