Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thickbox 3.1 #1029

Closed
robocoder opened this issue Oct 30, 2009 · 3 comments
Closed

Replace thickbox 3.1 #1029

robocoder opened this issue Oct 30, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
0.5

Comments

@robocoder
Copy link
Contributor

Issues:

  • FF3/Safari: feedback form; scrollbar(s) appear; worse in FF3 because submit button is obscured
  • ThickBox 3.1 is no longer maintained

Proposal:

  • replace thickbox with jquery-ui dialog.

Reference:
@pebosi
Copy link
Contributor

pebosi commented Nov 27, 2009

Attachment: Please review and try my patch to replace thickbox with jquery ui dialoh
piwik-dialog.patch

@pebosi
Copy link
Contributor

pebosi commented Nov 27, 2009

patch added.

@robocoder
Copy link
Contributor Author

In [1614], fixes #1029 - replace obsolete/unsupported thickbox with jqueryui dialog

Thanks pebosi!

Minor changes to patch to only add the iframe once and handle case where the Feedback plugin is disabled.

@robocoder robocoder added this to the Piwik 0.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@pebosi @robocoder