New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hitting the refresh button should refresh the exact same page #5523
Comments
Attachment: |
added patch for this ticket. ``` |
kpham, thanks for patch. I think however code can be improved, especially because in the future we’d like to persist more parameters than period/date/idsite/module/action therefore it should be modular. Feedback ``` This function would update the hash. Then it would trigger an event that says “onParametersUpdate” for example, and this function would do the job to call the right url in ajax to load below the menu (ie. there will be some menu code moved from existing javascript to this function). Later we could persist other parameters and add the code necessary to restore the page state in this function. What do you think about such a design? Other feedback on the code also: let me know what you think. |
Hi Matt, I agree with your comments. I will make those changes and re-submit another patch for this ticket. Looks like the back button doesn’t work as expected. Another problem is when you’re not login and use the anchor params; it doesn’t work. Thanks, |
just to emphasize that this is an important fix: it is mighty annoying that every time you change the date it will redirect you to the dashboard and you have to go back all the way! |
(In [1095]) - Refresh and back button now work! great contribution by Khanh Pham fixed #103 |
(In [1096]) it should work better with the main broadcast.js file :) refs #5523 |
This problem comes from the fact that we use ajax to load every content in piwik, so the URL remains the same all the time.
To fix this we can use the # in the URL, the same way Gmail does.
proposal
- at least following variables should be persisted in V1: day/period/idSite/module/action
- how to implement it? I would suggest the Facebook way (ie. the query after the #, eg. #module=Referers&action=getSearchEngines&idSite=1 etc.)
- see http://dev.piwik.org/trac/wiki/HowToTestUI which lists all UI features; good place to start to get a feeling of what is necessary to persist
Calendar
Currently changing the date in the calendar also changes the currently viewed section (reset to Dashboard).
Instead we should reload the same category.
Ressources
See [Jquery History](http://www.mikage.to/jquery/jquery_history.html)
jQuery history plugin: It uses the hash (fragment)
method that was mentioned earlier in this thread. You essentially need to be able to store some text that encapsulates the current page state so that it can be recreated by the browser on reload; no information beyond that in the URL is maintained in any reliable way. This particular plugin also has the effect of making the “back” and “forward” buttons undo and redo page state changes, which you may or may not want.
The text was updated successfully, but these errors were encountered: