Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separator to widget ID #1051

Closed
robocoder opened this issue Nov 29, 2009 · 1 comment
Closed

Add separator to widget ID #1051

robocoder opened this issue Nov 29, 2009 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
0.6

Comments

@robocoder
Copy link
Contributor

The current scheme has the potential for id collisions because there's no separator character between the module (plugin) name and the action (method) name, eg 'aaa' . 'bbb' == 'aa' . 'abbb'

Propose changing:

widgetVisitsSummarygetEvolutionGraph
widgetVisitorInterestgetNumberOfVisitsPerVisitDuration
widgetUserSettingsgetBrowser
... etc ...

to:

widgetVisitsSummary-getEvolutionGraph
widgetVisitorInterest-getNumberOfVisitsPerVisitDuration
widgetUserSettings-getBrowser
...
@mattab
Copy link
Member

mattab commented Mar 25, 2010

won't fix for now, as collisions are likely never going to happen with the naming scheme

@robocoder robocoder added this to the Piwik 0.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mattab @robocoder