New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 (native mode) regression: clicking on the table rows doesn't show the sub tables #1062
Comments
Same problem with IE8 (I think this is an general Internet Explorer problem). With 0.4.5 it work without any problems. |
Attachment: |
Tested against piwik.org/demo. Unable to reproduce. Subtables are expanding/collapsing as expected. See attached screenshot with IE7 on Vista. |
It's actually with IE8, sorry about misinformation ; can you reproduce in IE8? |
In [1671], refs #1062 - use IE7 compatibility mode for IE8; temporary workaround for jQuery bug in Sizzle |
Is this a known sizzle bug for sure? did you by any chance pin point the actual jquery selection that wasn't working in IE8 but should have? |
I tested it with 2 Piwik installations under vista/IE8 and subtables are expanding as |
jQuery 1.4.1 was released today. I'll hopefully find time to test this without the IE7 compatibility mode hack. |
(In [1802]) refs #1062 - fix IE8 compat buster in jQuery 1.4.1 where attr() may return null instead of undefined |
New regressions with jQuery 1.4.1 and IE8:
|
(In [1804]) refs #1062 - fix page load errors when Live widget added to dashboard |
Firefox regressions with jQuery 1.4.1:
|
Anthon, can you please clarify the current status of trunk for IE8 / IE7 / FF compatibility? Features such as add/delete widgets, anchors in subtables, datatable footers are all must-have in these 3 browsers. Is this working currently in trunk? |
Sure, to clarify: the regressions in comment:11 and comment:13 are not in trunk. The UI functionality in trunk is as it was in 0.5.4. I have not checked in the new versions of jquery and jquery-ui (or the related fixes that I'm working on) yet. I was expecting jquery-ui 1.8 final to be released yesterday, but I guess some blockers came up. |
Sorry, no native mode fix just yet. We'll keep the IE7 compat mode and jquery 1.3.2/jquery-ui 1.7.2 libs in place for a little while longer until I have more time to investigate all the compat busters with jquery 1.4.x and jquery-ui 1.8. When we do update the libs, we should reorganize the jquery folder a bit, relocating the uncompressed files (e.g., "original lib") and/or excluding these from the last.zip build. |
in IE8, clicking on a table's row, for example on a search engine row, doesn't open the list of keywords. No javascript errors are thrown.
Other features such as: sorting, filtering, displaying tag clouds, work as expected.
It shouldn't be a big deal but there might be some small imcompatibility between IE and FF in the datatable code? it is a regression as it was working in some earlier versions of Piwik in IE.
The text was updated successfully, but these errors were encountered: