Opened 4 years ago

Closed 4 years ago

#1068 closed New feature (fixed)

Internationalize the Goals plugin

Reported by: yareckon Owned by:
Priority: major Milestone: Piwik 0.5.5
Component: UI - UX (AngularJS, twig, less) Keywords: translation, de, en, Goals, plugin
Cc: Sensitive: no

Description

Hi guys,

attached is a patch against trunk/0.5.1 r1660/r1661 to internationalize the Goals plugin templates. Also included is a separate patch to provide those strings in the en.php fallback translation. I hope to provide a de.php version later this week.

Dunno if I'm setting this against the right milestone, so someone retarget this to 0.6 if only bugfixes go in 0.5.x

Attachments (3)

internationalizing-goals-plugin.txt (12.6 KB) - added by yareckon 4 years ago.
patching goals plugin template files
internationalizing-goals-plugin-lang.txt (3.9 KB) - added by yareckon 4 years ago.
patching /lang/en.php translations file
de.php.diff (2.8 KB) - added by yareckon 4 years ago.
Heres the update for lang/de.php

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by yareckon

patching goals plugin template files

Changed 4 years ago by yareckon

patching /lang/en.php translations file

Changed 4 years ago by yareckon

Heres the update for lang/de.php

comment:1 Changed 4 years ago by matt (mattab)

Thanks for that! is the patch covering all the strings in the Goals plugin templates?

comment:2 Changed 4 years ago by matt (mattab)

  • Priority changed from normal to major

comment:3 Changed 4 years ago by pebosi

Some js strings are missing, i will create an other patch to cover all strings.

regards

comment:4 Changed 4 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [1929] (for some reasons trac didn't auto closed this ticket?)

Fixes #1068 added i18n in all existing Goal plugin strings & js strings
updated documentation to explain how to translate JS strings in plugins + how to reload a widget in dashboard (this will be available in http://dev.piwik.org/trac/wiki/Plugins/GlobalFunctions after the release)

Note: See TracTickets for help on using tickets.