Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize the Goals plugin #1068

Closed
anonymous-matomo-user opened this issue Dec 10, 2009 · 6 comments
Closed

Internationalize the Goals plugin #1068

anonymous-matomo-user opened this issue Dec 10, 2009 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

Hi guys,

attached is a patch against trunk/0.5.1 r1660/r1661 to internationalize the Goals plugin templates. Also included is a separate patch to provide those strings in the en.php fallback translation. I hope to provide a de.php version later this week.

Dunno if I'm setting this against the right milestone, so someone retarget this to 0.6 if only bugfixes go in 0.5.x

Keywords: translation, de, en, Goals, plugin

@anonymous-matomo-user
Copy link
Author

Attachment: patching goals plugin template files
internationalizing-goals-plugin.txt

@anonymous-matomo-user
Copy link
Author

Attachment: patching /lang/en.php translations file
internationalizing-goals-plugin-lang.txt

@anonymous-matomo-user
Copy link
Author

Attachment: Heres the update for lang/de.php
de.php.diff

@mattab
Copy link
Member

mattab commented Dec 11, 2009

Thanks for that! is the patch covering all the strings in the Goals plugin templates?

@pebosi
Copy link
Contributor

pebosi commented Mar 9, 2010

Some js strings are missing, i will create an other patch to cover all strings.

regards

@mattab
Copy link
Member

mattab commented Mar 17, 2010

Fixed in [1929](for some reasons trac didn't auto closed this ticket?)

Fixes #1068 added i18n in all existing Goal plugin strings & js strings
updated documentation to explain how to translate JS strings in plugins + how to reload a widget in dashboard (this will be available in http://dev.piwik.org/trac/wiki/Plugins/GlobalFunctions after the release)

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.5.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants