New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer to check that all files are uploaded correctly during install / upgrades #1097
Comments
Marking it as feature request. This is an interesting improvement (I've seen it in Gallery installer before), but can take many seconds to execute, and adds a bit of overhead on the release process. If someone wants to grab the task and build it, please let us know. |
Change to build script:
|
Revised manifest generator for build script:
Timings from an (ancient) Athlon 1.4GHz test box:
|
For the UI part, I suggest that if the test fails, a red icon appears in the system checklist page. If it passes, it is just one more green item in the list (with required functions and librairies). |
(In [1756]) refs #1097 - file integrity check (optional) added to Installation. A warning is given if manifest.inc.php or md5_file() don't exist. Matt: please update the build script with the 'find' in comment:6 and then mark this ticket as fixed. |
Attachment: Standalone integrity test script |
Attachment: Sample (generated) manifest.inc.php (using piwik 0.5.4) |
(In [1757]) refs #1097 - exclude development environments; translate exception messages more php docs |
(In [1758]) refs #1097 - reorganize code to better accommodate an integrity check after an upgrade (not yet implemented in CoreUpdater) |
before marking as fixed, integrity check must happen during upgrades too. I will update the release script once this is code complete, nice work on this, this was a very frequent support issue. |
(In [1764]) refs #1097 - check file integrity after updates; simplify some messages (e.g., md5 sum) |
(In [1765]) refs #1097 - refactoring |
I think this will be a really great feature. |
Anthon, is the piwik code ready for this new feature? is the only thing left the one line update to the build script? |
Matt: yes, it's ready. While you're at it, please also add a line to the build script to remove unit test directories under the plugins folder.
|
Anthon, I added the find to delete the tests plugins folders and I get:
is that expected? |
good stuff Anthon! closing |
Yes, expected because 'find' is diving through folders while we remove it. We can suppress the messages using redirection, e.g, 2> /dev/null, or use xargs (if you don't mind the extra process being spawned), e.g.,
|
(In [1944]) Refs #1097 |
Support issue: users who upload (eg recursive ftp put) an already extracted Piwik folder. Files missing or corrupt.
Enhancement:
The text was updated successfully, but these errors were encountered: