Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1122 closed Bug (fixed)

plugins/*/API.php - E_STRICT cleanup

Reported by: vipsoft Owned by: vipsoft
Priority: normal Milestone: Piwik 0.5.5
Component: Core Keywords:
Cc: Sensitive: no

Description

For consistency (and to avoid E_STRICT warnings), public API functions should be declared as "static public". In many cases, it's simply "public" (or in some cases, implied).

Use of $this should be replaced with self::getInstance().

Change History (8)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [1817]) fixes #1122

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:3 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to vipsoft
  • Status changed from reopened to new

comment:4 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [1832]) fixes #1122 - per Matt's review

comment:5 Changed 4 years ago by vipsoft (robocoder)

(In [1833]) refs #1122 - fix usage

comment:6 Changed 4 years ago by vipsoft (robocoder)

(In [1834]) refs #1122 - fix core usage

comment:7 Changed 4 years ago by vipsoft (robocoder)

(In [1835]) refs #1122 - fix unit test

comment:8 Changed 4 years ago by matt (mattab)

Tu summarize, instead of changing all API methods to being static, we decided to change all callers to not call methods statically as this could cause various issues in the future. Thanks vipsoft!

Note: See TracTickets for help on using tickets.