New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browsers plugin graph report percentage instead of visits #1125
Comments
Requires changes to Visualization and ViewDataTable classes to support this chart type and |
Renaming and increasing priority. It would be easy to change the current graph and display percentage of users that have the plugin enabled. This would fix the main issue of this report. |
(In [2469]) refs #1125 now shows table instead of bar chart, displaying percentage of visits (excluding ie visits) |
would anyone please add the mentioned note to the view script/translation and close this ticket. |
Message proposal: patch looks good! |
(In [2474]) Refs #1125
|
(In [2493]) Fixes #1125
|
Attachment: after changes |
Bug, see screenshot: cookie detection works on IE therefore should not remove IE users (or % visits is higher than 100%) |
Attachment: |
I guess the best solution to get representive values for all is to calculate the cookie value including IE users and the rest without those. Or shall we include ie to all values? |
sounds good - I think we can leave the messaging as it is. |
(In [2519]) fixes #1125 include ie users for cookie value calculation, now works for multiple periods like last10 |
Wasn't as easy as I thought. The last change for the API-function didn't work for multiple periods like last10. So I had to change a bit more than only the cookie value calculation. Maybe anyone sees an easier way of doing this... |
code is too complicated I agree. Maybe this would be easy by writing a DataTable Filter? The Filter will access a standard datatable and therefore can contain the simple code contained currently in your API function. The datatable array will simply apply the filter to all datatable inside it. It would in this case update all stats, except cookies. Do you see what I mean? |
(In [2595]) Refs #1125
|
java detection seems to work in IE, too. see #1496 |
we can do this a bit later as code works as is. Let's focus on the secret project ;-) |
What's the remaining "todo" on this ticket? |
Code works as it is, but code complexity is still a bit too hight. see https://github.com/piwik/piwik/blob/master/plugins/UserSettings/API.php#L93 Maybe that could be solved a better way by using an tablefilter. Problem is that some plugins are treated a special way, as their detection does work in IE aswell. |
I'll take a look at the code and see if we can write a shorter version (maybe reusable). See also #1816 |
it seems sometimes the % visit might be wrong: http://wishuload.de/images/19232-42-2011-01-12142443.png |
See #2133 for code improvement now affecting another code Closing this ticket as request was implemented, SteveG your next patch will be closed a lot faster I promise :) |
The current view of the plugins used are meaningless.
You can see in the graph how many people support this plugin but you have to look to another widget to see the count of people traced.
If i see it right in ticket #852 there are no detection for IE.
Proposal:
Keywords: browser, plugin, chart
The text was updated successfully, but these errors were encountered: