Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserAgentParser issues #1167

Closed
robocoder opened this issue Feb 21, 2010 · 7 comments
Closed

UserAgentParser issues #1167

robocoder opened this issue Feb 21, 2010 · 7 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
0.5.5

Comments

@robocoder
Copy link
Contributor

getBrowser:

  • should GNU or Debian re-branded versions of Firefox and SeaMonkey be lumped together and shown as Firefox and SeaMonkey, respectively? Or should we separate these out as Icecat/Iceweasel and Iceape/GNUzilla?
  • should IE shells (e.g., AOL, CrazyBrowser) be reported as IE? if not, what about those without version numbers? (e.g., Acoo, Avant, GreenBrowser)
  • when adding a browser, oftentimes the browserFamily mapping has to be updated too. We should move this from UserSettings.php to the lib.
  • the parser should reject false matches on the Mozilla suite
  • if the browser/shell can switch layout engines, should we assign different browser_ids depending on the browser family?

getOperatingSystem:

  • should we break down Mac OS X by version? eg Leopard, Snow Tiger
@mattab
Copy link
Member

mattab commented Feb 22, 2010

  • I think GNU/Debian rebranded firefox should not appear in a different segments. These are firefox installs. Piwik reports browsers in order to help webmasters build their websites that are compatible with the most used browsers. If one is interested by the market share of debian based firefox, one can easily fetch the data from the logs and process it.
  • IE shells should be reported as IE
  • Agreed, the mapping Browser->Browser family should be moved to the UserAgentParser lib
  • browser switching layout engine- I think this is an edge case and there is not much we can do about it. We can just report the first detected engine and not care about subsequent changes.
  • If we break down OS by version, we have to do it for all OS (windows, Mac, Linux, etc.). There would be a new report "Operating Systems families" as well as the existing report broken down by OS version. The existing report would be slightly different in that Mac OS would be broken down by version.

thoughts?

@robocoder
Copy link
Contributor Author

  • I propose adding a FAQ item for the first three bullet points as a canned response when users request detection for a browser in these categories.
  • I'll move the browserTypes code.
  • I'll skip the MacOS breakdown.

@robocoder
Copy link
Contributor Author

(In [1859]) fixes #1165 - expand UserSettings unit test coverage;
fixes #1167 - fix UserAgentParser issues

@robocoder
Copy link
Contributor Author

(In [1861]) refs #1167 - revert Android browser ID for backward compat

@robocoder
Copy link
Contributor Author

(In [1862]) refs #1167 - revert Android browser ID for backward compat

@robocoder
Copy link
Contributor Author

re: [and 1862 - there is no backward compat issue as the Android browser ID was added post-0.5.4

@robocoder
Copy link
Contributor Author

(In [1863]) refs #1167 - revert change to IRIX os ID for backward compat

@robocoder robocoder added this to the Piwik 0.5.5 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
@nidico nidico mentioned this issue Dec 4, 2015
Closed
@nidico nidico mentioned this issue Dec 23, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
0.5.5
Development

No branches or pull requests
2 participants
@mattab @robocoder