Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script improvements #1213

Closed
robocoder opened this issue Mar 18, 2010 · 5 comments
Closed

Update script improvements #1213

robocoder opened this issue Mar 18, 2010 · 5 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

Pain points:

  • browser times out on lengthy updates
  • users without shell access
  • failing because users lack sufficient mysql privileges

Pseudo-code:

pre-flight checklist (useful at time of installation too)

if not php cli mode
    ignore_user_abort
    disable max_execution_time

    if exec() is not disabled
        exec('nohup php index.php >/dev/null 2>/dev/null &') // run the update in the background
        redirect to tmp/latest/progress.html // a static file that is overwritten by the updater
    else
        run updater // for each update, echo 'something' to the client and flush output buffers to (try) keep connection alive

else
    run updater // foreach update, write to progress.html

See also #910
@mattab
Copy link
Member

mattab commented Mar 20, 2010

Anthon, we've made some good improvements to the update screen in 0.5.5 and users have not had issues it seems. I'd like to move this to post 1.0 - thoughts?

@robocoder
Copy link
Contributor Author

Insuffiicient permissions is still a problem. So, at minimum, we should do the pre-update check before 1.0.

@mattab
Copy link
Member

mattab commented Mar 20, 2010

I missed that first line.

My suggestion would be to be to show the report only if there are errors (not warnings, as warnings could have been shown during the install too and would be the same). The exception being the file integrity warnings that we already display.

That said, I think this would be a must do only if we happen the change the requirements (that would trigger an "error") for Piwik before 1.0.

@robocoder
Copy link
Contributor Author

Looks like I already had a ticket for the pre-flight. #927

@mattab
Copy link
Member

mattab commented Jan 16, 2011

I just tested piwik upgrade on a 10Gb piwik_log_* DB and the shell option worked like a charm. I don't think there would be users without shell option and with a very large DB that would cause problem in the UI.

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder