Opened 4 years ago

Closed 4 years ago

#1215 closed Bug (fixed)

"File size mismatch" warning with a modified robots.txt

Reported by: larsen Owned by: vipsoft
Priority: normal Milestone: Piwik 0.6
Component: Core Keywords:
Cc: Sensitive: no

Description

Piwik´s own robots.txt is empty, but as the reporter from ticket #431 mentioned a global disallowed is the desired behaviour in most cases.

Starting with the file integrity check in Piwik 0.5.5 you get a warning when you have changed the robots.txt what I guess several people will have done.

To prevent this, robots.txt should not be checked.

Change History (8)

comment:1 Changed 4 years ago by matt (mattab)

  • Milestone set to 1 - Piwik 0.5.6

comment:2 Changed 4 years ago by vipsoft (robocoder)

Vote to simply remove robots.txt from the distro because:

  • it is not checked by crawlers if Piwik is installed in a subfolder of the web document root
  • it is overwritten by the auto-update
  • it's empty!

comment:3 Changed 4 years ago by vipsoft (robocoder)

Part 2:

  • enhance installer to create robots.txt if Piwik is installed in the web document root, otherwise warn user and provide sample exclusion

comment:4 Changed 4 years ago by matt (mattab)

We initially put the robots.txt because otherwise, when Piwik is installed in a subdomain, it shows up as 404 in the error logs, which is a nuisance.

Maybe we can

  • not overwrite it during automatic upgrades
  • not check it in the file integrity check

which would give us the best of both worlds?

comment:5 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to vipsoft

I'll modify the installer to simply create an empty robots.txt in the piwik root if it doesn't already exist, rather than creating exceptions in the updater and integrity check.

comment:6 Changed 4 years ago by matt (mattab)

I think this will be an issue as it would require write permissions on the root folder, which are currently not required..

comment:7 Changed 4 years ago by vipsoft (robocoder)

On review, why not re-open #431 and implement the original recommendation?

comment:8 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [1957]) fixes #1215 - protect locally modified 'robots.txt'; skip file integrity check and don't overwrite when updating

Note: See TracTickets for help on using tickets.