Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"File size mismatch" warning with a modified robots.txt #1215

Closed
anonymous-matomo-user opened this issue Mar 19, 2010 · 7 comments
Closed

"File size mismatch" warning with a modified robots.txt #1215

anonymous-matomo-user opened this issue Mar 19, 2010 · 7 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

Piwiks own robots.txt is empty, but as the reporter from ticket #431 mentioned a global disallowed is the desired behaviour in most cases.

Starting with the file integrity check in Piwik 0.5.5 you get a warning when you have changed the robots.txt what I guess several people will have done.

To prevent this, robots.txt should not be checked.

@robocoder
Copy link
Contributor

Vote to simply remove robots.txt from the distro because:

  • it is not checked by crawlers if Piwik is installed in a subfolder of the web document root
  • it is overwritten by the auto-update
  • it's empty!

@robocoder
Copy link
Contributor

Part 2:

  • enhance installer to create robots.txt if Piwik is installed in the web document root, otherwise warn user and provide sample exclusion

@mattab
Copy link
Member

mattab commented Mar 19, 2010

We initially put the robots.txt because otherwise, when Piwik is installed in a subdomain, it shows up as 404 in the error logs, which is a nuisance.

Maybe we can

  • not overwrite it during automatic upgrades
  • not check it in the file integrity check

which would give us the best of both worlds?

@robocoder
Copy link
Contributor

I'll modify the installer to simply create an empty robots.txt in the piwik root if it doesn't already exist, rather than creating exceptions in the updater and integrity check.

@mattab
Copy link
Member

mattab commented Mar 19, 2010

I think this will be an issue as it would require write permissions on the root folder, which are currently not required..

@robocoder
Copy link
Contributor

On review, why not re-open #431 and implement the original recommendation?

@robocoder
Copy link
Contributor

(In [1957]) fixes #1215 - protect locally modified 'robots.txt'; skip file integrity check and don't overwrite when updating

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants