Opened 4 years ago

Closed 4 years ago

#1283 closed New feature (fixed)

Bing image Search

Reported by: eagle Owned by:
Priority: normal Milestone: Piwik 0.6.2
Component: Core Keywords:
Cc: Sensitive: no

Description

Maybe it would be useful to add the Bing Image search to the search engines.

		// Bing Images
		'www.bing.com/images/'		=> array('bing.com', 'search', 'http://www.bing.com/images/search?q={k}'

Hope it works

Change History (8)

comment:1 Changed 4 years ago by vipsoft (robocoder)

"hope it works"? Can you test it?

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Keywords bing images removed

comment:3 Changed 4 years ago by vipsoft (robocoder)

  • Keywords interesting added
  • Resolution set to wontfix
  • Status changed from new to closed

The current logic is on the domain name, excluding the path. To implement this enhancement would require changes to Piwik.php extractSearchEngineInformationFromUrl().

Marking as wontfix, but invite anyone to submit a clean patch.

comment:4 Changed 4 years ago by matt (mattab)

  • Milestone changed from 1 - Piwik 0.6 to 5 - Piwik 1.0 - Stable release

Note that Google images is handled using a manual hack, see http://dev.piwik.org/trac/browser/trunk/core/Common.php#L945

Such similar hack could be used for bing images

comment:5 Changed 4 years ago by vipsoft (robocoder)

  • Milestone changed from 4 - Piwik 1.0 - Stable release to 0 - Piwik 0.6.2
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Let's try to fix this at the same time as #1348

comment:6 Changed 4 years ago by vipsoft (robocoder)

  • Status changed from reopened to new

comment:7 Changed 4 years ago by vipsoft (robocoder)

  • Keywords interesting removed

comment:8 Changed 4 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2175]) Fixes #1283 Bing images search. I haven't tested in the UI and checked that the link to the keyword works.

Note: See TracTickets for help on using tickets.