Opened 4 years ago

Closed 4 years ago

#1300 closed Bug (fixed)

(X)HTML elements don't have unique ids

Reported by: vipsoft Owned by: vipsoft
Priority: major Milestone: Piwik 0.6.2
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft)

The id attribute must be unique within a document. This is a problem on the Dashboard with jquery 1.4.x (and its optimized selector code).

Reference: http://www.w3.org/TR/html401/struct/global.html#h-7.5.2

Examples (non-exhaustive list):

  • <div id="emptyDatatable">
  • <div id="dataTableFeatures">
  • <span id="dataTablePages"/>
  • <span id="dataTablePrevious">
  • <span id="dataTableNext">
  • <span id="dataTableSearchPattern" ...>
  • <input id="keyword" ...>
  • <span id="dataTableFooterIcons" ...>
  • <span id="exportToFormat" ...>
  • <span id="linksExportToFormat" ...>
  • <span id="dataTableFooterIconsShow" ...>
  • <span id="tableAllColumnsSwitch" ...>
  • <span id="loadingDataTable">

See also: #950, #1235

Change History (3)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Description modified (diff)

comment:2 Changed 4 years ago by matt (mattab)

I dont think we should change this now as this wouldn't change anything, plus in the feature I think it would make more sense to rewrite the datatable JS code to make it more simple (only read JSON from server and have the presentation fully in JS, rather than hacking the DOM as it is now).
vote for wontfix

comment:3 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2161]) fixes #1300

Note: See TracTickets for help on using tickets.