Ticket #1300 (closed Bug: fixed)

Opened 22 months ago

Last modified 21 months ago

(X)HTML elements don't have unique ids

Reported by: vipsoft Owned by: vipsoft
Priority: major Milestone: Piwik 0.6.2
Component: UI (templates, javascript) Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft) (diff)

The id attribute must be unique within a document. This is a problem on the Dashboard with jquery 1.4.x (and its optimized selector code).

Reference:  http://www.w3.org/TR/html401/struct/global.html#h-7.5.2

Examples (non-exhaustive list):

  • <div id="emptyDatatable">
  • <div id="dataTableFeatures">
  • <span id="dataTablePages"/>
  • <span id="dataTablePrevious">
  • <span id="dataTableNext">
  • <span id="dataTableSearchPattern" ...>
  • <input id="keyword" ...>
  • <span id="dataTableFooterIcons" ...>
  • <span id="exportToFormat" ...>
  • <span id="linksExportToFormat" ...>
  • <span id="dataTableFooterIconsShow" ...>
  • <span id="tableAllColumnsSwitch" ...>
  • <span id="loadingDataTable">

See also: #950, #1235

Change History

Changed 22 months ago by vipsoft

  • description modified (diff)

Changed 22 months ago by matt

I dont think we should change this now as this wouldn't change anything, plus in the feature I think it would make more sense to rewrite the datatable JS code to make it more simple (only read JSON from server and have the presentation fully in JS, rather than hacking the DOM as it is now). vote for wontfix

Changed 21 months ago by vipsoft

  • status changed from new to closed
  • resolution set to fixed

(In [2161]) fixes #1300

Note: See TracTickets for help on using tickets.