Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(X)HTML elements don't have unique ids #1300

Closed
robocoder opened this issue Apr 12, 2010 · 2 comments
Closed

(X)HTML elements don't have unique ids #1300

robocoder opened this issue Apr 12, 2010 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

The id attribute must be unique within a document. This is a problem on the Dashboard with jquery 1.4.x (and its optimized selector code).

Reference: http://www.w3.org/TR/html401/struct/global.html#h-7.5.2

Examples (non-exhaustive list):

  • <div id="emptyDatatable">
  • <div id="dataTableFeatures">
  • <span id="dataTablePages"/>
  • <span id="dataTablePrevious">
  • <span id="dataTableNext">
  • <span id="dataTableSearchPattern" ...>
  • <input id="keyword" ...>
  • <span id="dataTableFooterIcons" ...>
  • <span id="exportToFormat" ...>
  • <span id="linksExportToFormat" ...>
  • <span id="dataTableFooterIconsShow" ...>
  • <span id="tableAllColumnsSwitch" ...>
  • <span id="loadingDataTable">

See also: #950, #1235

@mattab
Copy link
Member

mattab commented Apr 13, 2010

I dont think we should change this now as this wouldn't change anything, plus in the feature I think it would make more sense to rewrite the datatable JS code to make it more simple (only read JSON from server and have the presentation fully in JS, rather than hacking the DOM as it is now).
vote for wontfix

@robocoder
Copy link
Contributor Author

(In [2161]) fixes #1300

@robocoder robocoder added this to the Piwik 0.6.2 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants