Opened 4 years ago

Closed 4 years ago

#1344 closed Bug (fixed)

Fix missing translations in Goals plugin

Reported by: halfdan Owned by:
Priority: normal Milestone: Piwik 0.6.2
Component: Core Keywords:
Cc: Sensitive: no

Description

The Goals plugin didn't show the proper translation for it's menu items.

Reason:

  • Piwik_AddMenu was used without a proper translation string. (Goals_AddNewGoal)
  • No translation for menu item found -> Goals_Overview created.

Please add the line:
"Goals_Overview" => "Overview",

to the en.php.

Attachments (2)

form_add_goal.tpl.diff (157 bytes) - added by halfdan 4 years ago.
Goals.php.diff (700 bytes) - added by halfdan 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by halfdan

Additionally add

'Goals_WhereThe' => 'where the',

to the en.php as the string "where the" was hardcoded in templates/form_add_goal.tpl.

Fixed in attachment.

Changed 4 years ago by halfdan

comment:2 Changed 4 years ago by halfdan

I've overlooked the most obvious translation - the menu item. To summarise the changes:
Add:

'Goals_Overview' => 'Overview',
'Goals_Goals' => 'Goals',
'Goals_WhereThe' => 'where the',

to en.php and apply the last comitted diffs.

Changed 4 years ago by halfdan

comment:3 Changed 4 years ago by vipsoft (robocoder)

  • Priority changed from major to normal

comment:4 Changed 4 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2172]) Fixes #1344 thanks halfdan for patch!

Note: See TracTickets for help on using tickets.