Ticket #1344 (closed Bug: fixed)

Opened 21 months ago

Last modified 21 months ago

Fix missing translations in Goals plugin

Reported by: halfdan Owned by:
Priority: normal Milestone: Piwik 0.6.2
Component: Core Keywords:
Cc: Sensitive: no

Description

The Goals plugin didn't show the proper translation for it's menu items.

Reason: - Piwik_AddMenu was used without a proper translation string. (Goals_AddNewGoal) - No translation for menu item found -> Goals_Overview created.

Please add the line: "Goals_Overview" => "Overview",

to the en.php.

Attachments

form_add_goal.tpl.diff Download (157 bytes) - added by halfdan 21 months ago.
Goals.php.diff Download (0.7 KB) - added by halfdan 21 months ago.

Change History

Changed 21 months ago by halfdan

Additionally add

'Goals_WhereThe' => 'where the',

to the en.php as the string "where the" was hardcoded in templates/form_add_goal.tpl.

Fixed in attachment.

Changed 21 months ago by halfdan

Changed 21 months ago by halfdan

I've overlooked the most obvious translation - the menu item. To summarise the changes: Add:

'Goals_Overview' => 'Overview', 'Goals_Goals' => 'Goals', 'Goals_WhereThe' => 'where the',

to en.php and apply the last comitted diffs.

Changed 21 months ago by halfdan

Changed 21 months ago by vipsoft

  • priority changed from major to normal

Changed 21 months ago by matt

  • status changed from new to closed
  • resolution set to fixed

(In [2172]) Fixes #1344 thanks halfdan for patch!

Note: See TracTickets for help on using tickets.