Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing translations in Goals plugin #1344

Closed
halfdan opened this issue May 8, 2010 · 5 comments
Closed

Fix missing translations in Goals plugin #1344

halfdan opened this issue May 8, 2010 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@halfdan
Copy link
Member

halfdan commented May 8, 2010

The Goals plugin didn't show the proper translation for it's menu items.

Reason:

  • Piwik_AddMenu was used without a proper translation string. (Goals_AddNewGoal)
  • No translation for menu item found -> Goals_Overview created.

Please add the line:
"Goals_Overview" => "Overview",

to the en.php.

@halfdan
Copy link
Member Author

halfdan commented May 8, 2010

Additionally add

'Goals_WhereThe' => 'where the',

to the en.php as the string "where the" was hardcoded in templates/form_add_goal.tpl.

Fixed in attachment.

@halfdan
Copy link
Member Author

halfdan commented May 8, 2010

Attachment:
form_add_goal.tpl.diff

@halfdan
Copy link
Member Author

halfdan commented May 9, 2010

I've overlooked the most obvious translation - the menu item. To summarise the changes:
Add:

'Goals_Overview' => 'Overview',
'Goals_Goals' => 'Goals',
'Goals_WhereThe' => 'where the',

to en.php and apply the last comitted diffs.

@halfdan
Copy link
Member Author

halfdan commented May 9, 2010

Attachment:
Goals.php.diff

@mattab
Copy link
Member

mattab commented May 13, 2010

(In [2172]) Fixes #1344 thanks halfdan for patch!

@halfdan halfdan added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants