Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik One Click Update fails with bogus error if curl_exec times out #1345

Closed
jpfleury opened this issue May 8, 2010 · 14 comments
Closed

Piwik One Click Update fails with bogus error if curl_exec times out #1345

jpfleury opened this issue May 8, 2010 · 14 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@jpfleury
Copy link

jpfleury commented May 8, 2010

Piwik One Click Update from 0.5.5 to 0.6.1 fails with these errors:

Archive incompatible: PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature

Piwik One Click Update has been cancelled. If you can't fix the above error message, it is recommended that you manually update Piwik.

Please check out the Update documentation to get started!

@robocoder
Copy link
Contributor

What is the file size of piwik/tmp/latest/latest.zip?

@jpfleury
Copy link
Author

jpfleury commented May 9, 2010

Replying to vipsoft:

What is the file size of piwik/tmp/latest/latest.zip?

0 octet.

@robocoder
Copy link
Contributor

Assuming you didn't run out of disk space... Piwik wasn't able to download the .zip file.

I can add a check for the empty file, but I'd like to know if we can better detect why the download was attempted and failed. Can you check your phpinfo() ? I'm curious about extensions you have (e.g., curl, socket), and settings such as "disable_functions" and "suhosin.executor.func.blacklist".

@robocoder
Copy link
Contributor

Scratch that. I see the problem.

@robocoder
Copy link
Contributor

(In [2166]) fixes #1345 - for curl, use CONNECTTIMEOUT (timeout to connect) instead of TIMEOUT (time to complete curl operation) as the .zip file has increased in size, and the server (and/or network) seems slower; improve error checking

@mattab
Copy link
Member

mattab commented May 9, 2010

did you also try to download it several times? we sometimes reboot the server, which would cause any download to fail. Retrying a few minutes later should work, if that was the issue. Anthon, your change sounds good too.

@jpfleury
Copy link
Author

jpfleury commented May 9, 2010

Replying to matt:

did you also try to download it several times?

Yes, in different times of the day and for different Piwik's installations.

@jpfleury
Copy link
Author

jpfleury commented May 9, 2010

Replying to vipsoft:

Can you check your phpinfo() ? I'm curious about extensions you have (e.g., curl, socket), and settings such as "disable_functions" and "suhosin.executor.func.blacklist".

Do you still need this info?

@robocoder
Copy link
Contributor

It was really slow last nite, so I saw it timeout after transferring ~700kB.

jpfle: you may still need to manually update from 0.6.1 to 0.6.2 if the slowdown persists, as you obviously won't have the fix until after you update.

@mattab
Copy link
Member

mattab commented May 9, 2010

if/when the problem becomes a larger issue, we can 'mirror' the downloads. I don't know how it would technically work if we would like to keep the existing URL piwik.org/latest.zip?

@robocoder
Copy link
Contributor

Since we get the latest version number available, it should be trivial to determine the named file, eg 0.6.2 => piwik-0.6.2.zip, and retrieve that instead of latest.zip (in case a mirror has not synced up yet).

@robocoder
Copy link
Contributor

We'd lose direct tracking of download stats, but I believe we can rsync our releases onto SourceForge's mirror network.

@robocoder
Copy link
Contributor

(In [2185]) refs #1345 - tested with PHP 5.1.6; for fetchRemoteFile(), we now ask curl to write directly to the destination file

@robocoder
Copy link
Contributor

In [2207], refs #1345 - handle negative Content-Length; in libcurl >= 7.12.1, the curl extension will ignore negative Content-Length

@jpfleury jpfleury added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants