Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing search engine favicons #1350

Closed
halfdan opened this issue May 11, 2010 · 13 comments
Closed

Adding missing search engine favicons #1350

halfdan opened this issue May 11, 2010 · 13 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@halfdan
Copy link
Member

halfdan commented May 11, 2010

Collecting missing search engine favicons here.
Keywords: favicon

@halfdan
Copy link
Member Author

halfdan commented May 11, 2010

Attachment:
meta.rrzn.uni-hannover.de.png

@halfdan
Copy link
Member Author

halfdan commented May 11, 2010

Attachment:
search.babylon.com.png

@halfdan
Copy link
Member Author

halfdan commented May 11, 2010

Attachment:
hooseek.com.png

@robocoder
Copy link
Contributor

halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)?

p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed.

@mattab
Copy link
Member

mattab commented May 11, 2010

we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size.

@halfdan
Copy link
Member Author

halfdan commented May 11, 2010

matt: alright
vipsoft: Sure, I'd just write a script to fetch all favicons.

The icons above are just those that were missing in my/the piwik demo stats.

@robocoder
Copy link
Contributor

I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size.

(BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.)

@mattab
Copy link
Member

mattab commented May 11, 2010

Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them)

Also OK I didn't realize that most icons were already in there.

@halfdan
Copy link
Member Author

halfdan commented May 11, 2010

Alright, assign me this ticket - I'll add the missing favicons.

@halfdan
Copy link
Member Author

halfdan commented May 12, 2010

Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php?

In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy.

@halfdan
Copy link
Member Author

halfdan commented May 14, 2010

Attachment: Script to fetch missing and list not needed favicons.
ProcessFavicons.zip

@halfdan
Copy link
Member Author

halfdan commented May 14, 2010

Attachment: Favicons + List of not needed favicons
Favicons.zip

@robocoder
Copy link
Contributor

(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script

@halfdan halfdan added this to the Piwik 0.6.2 milestone Jul 8, 2014
@halfdan halfdan self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants