Opened 4 years ago

Closed 4 years ago

#1350 closed Bug (fixed)

Adding missing search engine favicons

Reported by: halfdan Owned by: halfdan
Priority: low Milestone: Piwik 0.6.2
Component: Core Keywords: favicon
Cc: Sensitive: no

Description

Collecting missing search engine favicons here.

Attachments (5)

meta.rrzn.uni-hannover.de.png (160 bytes) - added by halfdan 4 years ago.
search.babylon.com.png (1008 bytes) - added by halfdan 4 years ago.
hooseek.com.png (536 bytes) - added by halfdan 4 years ago.
ProcessFavicons.zip (958 bytes) - added by halfdan 4 years ago.
Script to fetch missing and list not needed favicons.
Favicons.zip (69.7 KB) - added by halfdan 4 years ago.
Favicons + List of not needed favicons

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by halfdan

Changed 4 years ago by halfdan

comment:1 Changed 4 years ago by vipsoft (robocoder)

halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)?

p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed.

comment:2 Changed 4 years ago by matt (mattab)

we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size.

comment:3 Changed 4 years ago by halfdan

matt: alright
vipsoft: Sure, I'd just write a script to fetch all favicons.

The icons above are just those that were missing in my/the piwik demo stats.

comment:4 Changed 4 years ago by vipsoft (robocoder)

I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size.

(BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.)

comment:5 Changed 4 years ago by matt (mattab)

Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them)

Also OK I didn't realize that most icons were already in there.

comment:6 Changed 4 years ago by halfdan

Alright, assign me this ticket - I'll add the missing favicons.

comment:7 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to halfdan

comment:8 Changed 4 years ago by halfdan

Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php?

In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy.

Changed 4 years ago by halfdan

Script to fetch missing and list not needed favicons.

Changed 4 years ago by halfdan

Favicons + List of not needed favicons

comment:9 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script

Note: See TracTickets for help on using tickets.