New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing search engine favicons #1350
Comments
Attachment: |
Attachment: |
Attachment: |
halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)? p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed. |
we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size. |
matt: alright The icons above are just those that were missing in my/the piwik demo stats. |
I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size. (BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.) |
Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them) Also OK I didn't realize that most icons were already in there. |
Alright, assign me this ticket - I'll add the missing favicons. |
Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php? In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy. |
Attachment: Script to fetch missing and list not needed favicons. |
Attachment: Favicons + List of not needed favicons |
(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script |
Collecting missing search engine favicons here.
Keywords: favicon
The text was updated successfully, but these errors were encountered: