Ticket #1350 (closed Bug: fixed)

Opened 21 months ago

Last modified 21 months ago

Adding missing search engine favicons

Reported by: halfdan Owned by: halfdan
Priority: low Milestone: Piwik 0.6.2
Component: Core Keywords: favicon
Cc: Sensitive: no

Description

Collecting missing search engine favicons here.

Attachments

meta.rrzn.uni-hannover.de.png Download (160 bytes) - added by halfdan 21 months ago.
search.babylon.com.png Download (1.0 KB) - added by halfdan 21 months ago.
hooseek.com.png Download (0.5 KB) - added by halfdan 21 months ago.
ProcessFavicons.zip Download (0.9 KB) - added by halfdan 21 months ago.
Script to fetch missing and list not needed favicons.
Favicons.zip Download (69.7 KB) - added by halfdan 21 months ago.
Favicons + List of not needed favicons

Change History

Changed 21 months ago by halfdan

Changed 21 months ago by halfdan

Changed 21 months ago by halfdan

Changed 21 months ago by vipsoft

halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)?

p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed.

Changed 21 months ago by matt

we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size.

Changed 21 months ago by halfdan

matt: alright vipsoft: Sure, I'd just write a script to fetch all favicons.

The icons above are just those that were missing in my/the piwik demo stats.

Changed 21 months ago by vipsoft

I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size.

(BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.)

Changed 21 months ago by matt

Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them)

Also OK I didn't realize that most icons were already in there.

Changed 21 months ago by halfdan

Alright, assign me this ticket - I'll add the missing favicons.

Changed 21 months ago by vipsoft

  • owner set to halfdan

Changed 21 months ago by halfdan

Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php?

In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy.

Changed 21 months ago by halfdan

Script to fetch missing and list not needed favicons.

Changed 21 months ago by halfdan

Favicons + List of not needed favicons

Changed 21 months ago by vipsoft

  • status changed from new to closed
  • resolution set to fixed

(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script

Note: See TracTickets for help on using tickets.