New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check and translate errors/exceptions displayed on screen or returned in API calls #1351
Comments
Yes, lots of exception string messages to translate... |
Yeah let's rename this ticket to include all Exception or error messages (displayed to the user screen) yet to be translated. |
I propose to do it file by file. Here is core/API/Proxy.php |
Attachment: |
Attachment: |
Please advise on message key string for exception /core/Archive/Array/IndexedBySite.php#111 :
|
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
do not consider file core.DataTable.Renderer.2.patch |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Please advise on message key string for exceptions : /core/SmartyPlugins/function.loadJavascriptTranslations.php#37 :
/core/SmartyPlugins/function.postEvent.php#34 :
/core/SmartyPlugins/modifier.money.php#22 :
|
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Attachment: |
Julien, thanks for the patches - can you please submit one patch that contains all changes? Otherwise, there are many exception messages that don't need to be translated, as they are never displayed on screen (or when they are, this is not an expected error and it doesn't need to be translated). Example of exceptions that should never display on user screen (unless a plugin is buggy, or something else went very wrong) and therefore don't need to be translated:
Basically all exceptions that we translate should not mention 'code specific' issues and should let the user know, in non technical terms, what the error is and why it happened. Let me know if that makes sense |
Replying to JulienM:
these strings don't need to be translated as they would not appear on screen except during the development of a plugin (and in this case, it's OK to show english to the dev) |
Patch 1351.patch externalizes exceptions marked in translated-exceptions.html |
Attachment: |
Attachment: |
Attachment: |
(In [2246]) Fixes #1351 All error messages displayed to screen/API should not be translated. Thanks JulienM for patch! I simply refactored the 'you must be have %s access [...]' messages by putting the admin/view/superuser as a parameter in the string |
I saw that core/Access.php has lots of strings that are not getting translated. This should be fixed.
Keywords: translation
The text was updated successfully, but these errors were encountered: