Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing translations in title tag of several header.tpl #1354

Closed
hansfn opened this issue May 12, 2010 · 5 comments
Closed

Fix missing translations in title tag of several header.tpl #1354

hansfn opened this issue May 12, 2010 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@hansfn
Copy link

hansfn commented May 12, 2010

Line 5 of plugins/CoreAdminHome/templates/header.tpl - hard coded "Administration".

Line 5 of plugins/CoreHome/templates/header.tpl - hard coded "Web Analytics Reports".

Line 5 of plugins/Login/templates/header.tpl - hard coded "Login".

These issues are quite important since the title is a very visible thing.

@halfdan
Copy link
Member

halfdan commented May 12, 2010

Attachment:
patch

@halfdan
Copy link
Member

halfdan commented May 12, 2010

Patch fixes all three issues.

Note: I used the key Login_LogIn in en.php to translate "Login". This is currently (for some reason) set to "Sign In".

@mattab
Copy link
Member

mattab commented May 13, 2010

(In [2176]) Fixes #1354

@mattab
Copy link
Member

mattab commented May 13, 2010

I applied the patch but it wasn't working (missing single quotes) please test your patches before submitting. thx

@robocoder
Copy link
Contributor

(In [refs #1354, 2176)

@hansfn hansfn added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

4 participants