New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisitorGenerator plugin #1374
Comments
Attachment: |
Attachment: |
Just took a cursory look. For future reference, please indent using tab stops every 4 spaces. See wiki:CodingStandard Are you sure you meant #762? That ticket was to move core/Tracker/Generator.php, core/Tracker/Generator/, and misc/generateVisitsData/ into a plugin. |
Mh, indeed #762 is a wrong reference. I re-uploaded the archive. Tab indent should comply to the Coding Standard now. |
I think this is a good improvement to the current visit generator. code review:
We will use data from this website as golden logs: divezone.net - diving guide since it is a classic piwik use case website. |
IIRC core/Tracker/Generator/* has hardcoded references to misc/generateVisitsData, so it would be more self-contained to move these into the plugin as well. |
matt: Alright, thanks for review. Adjusted everything and added patch to add the plugin. I moved core/Tracker/Generator.php, core/Tracker/Generator/* and misc/generateVisitsData/* into the plugin. |
code review
|
New patch, all fixed. |
The patch seems to be missing the files core/Tracker/Generator/* in the plugin itself? |
They have been moved into the plugin itself (see Tracker.php, etc.) |
yes but they are not in the patch, so when applying the patch, i get the error 'file missing xxx' |
Very strange - reuploaded the patch, according to the trac output it should fix the problem. |
it seems your patch is not against trunk. For example, plugins/VisitorGenerator/Generator.php is a DIFF but this file doesn't exist in trunk, so it should be the full file in the patch. do you see what I mean? |
matt: Yep, I see. Sorry for that, I exported another patch (this time using Netbeans - looked good to me). I seriously need to switch back to my Linux development machine, SVN under Windows is a pain :( |
Attachment: |
Attachment: VisitorGenerator plugin + en.php.patch |
(In [2245]) Refs #1374 Moving visitor generator tool to its own plugin. Patch by halfdan! Also renamed setPluginsToLoad to loadPlugins() |
Thanks for the patch! Note:
Thanks! |
Attachment: |
I knew I missed something ;) Added the patch for the API template. Thanks for integrating that into the core. |
(In [2247]) Fixes #1374 Patch by halfdan I modified it a bit to simplify the translation messages |
Just noticed that my patch is missing the templates for the VisitorGenerator plugin sigh. It's attached now.. |
Attachment: |
(In [2257]) fixes #1374 - check in the missing templates |
After #762, #1369 and #1371 I took the liberty and refactored the generateVisits.php into an own plugin (see Attachment). Basically the plugin replaces the generateVisits.php and introduces a smarter interface which can be called from a browser. It does not provide a CLI though.
When the plugin is activated it adds itself to the AdminMenu (if the user is SuperUser).
I set milestone to 0.6.2 as I think this can be easily included into the core. Fell free to change this to third party plugins.
The text was updated successfully, but these errors were encountered: