Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.1.6 notices and errors #1378

Closed
robocoder opened this issue May 25, 2010 · 9 comments
Closed

PHP 5.1.6 notices and errors #1378

robocoder opened this issue May 25, 2010 · 9 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

Reported on forum http://forum.piwik.org/index.php?showtopic=9651

Fatal error: Call to a member function getColumn() on a non-object in /PATH/core/DataTable/Filter/Sort.php on line 120

Unit tests:

Exception: ../tests/core/DataTable.test.php -> Test_Piwik_DataTable -> test_getLastRow -> Unexpected PHP error [Object of class Piwik_DataTable_Row to string conversion] severity [E_NOTICE] in [/PATH/tests/simpletest/test_case.php line 312]

and:

Fatal error: Call to undefined function json_encode() in /PATH/core/DataTable/Renderer/Json.php on line 39
@robocoder
Copy link
Contributor Author

Added libs/upgradephp/upgrade.php to config_test.php. Additional errors:

Fail: ../tests/core/TablePartitioning.test.php -> Test_Piwik_TablePartitioning -> test_noTable -> Equal expectation fails at character 0 with [piwik_archive_numeric_2000_09] and [Object id #358] at [PATH/tests/core/TablePartitioning.test.php line 51]
Fail: ../tests/core/TablePartitioning.test.php -> Test_Piwik_TablePartitioning -> test_monthlyPartition -> Equal expectation fails at character 0 with [piwik_archive_numeric_2000_09] and [Object id #1295] at [PATH/tests/core/TablePartitioning.test.php line 71]
Fail: ../tests/core/TablePartitioning.test.php -> Test_Piwik_TablePartitioning -> test_dailyPartition -> Equal expectation fails at character 0 with [piwik_archive_numeric_2000_09_10] and [Object id #997] at [PATH/tests/core/TablePartitioning.test.php line 91]

Fail: ../plugins/SitesManager/tests/SitesManager.test.php -> Test_Piwik_SitesManager -> test_setDefaultTimezoneAndCurrencyAndExcludedQueryParametersAndExcludedIps -> Equal expectation fails as [Object: of Piwik_Date] does not match [String: 2010-05-27] at [PATH/plugins/SitesManager/tests/SitesManager.test.php line 783]

Exception: ../plugins/SitesManager/tests/SitesManager.test.php -> Test_Piwik_SitesManager -> test_setDefaultTimezoneAndCurrencyAndExcludedQueryParametersAndExcludedIps -> Unexpected PHP error [Object of class Piwik_Date could not be converted to int] severity [E_NOTICE] in [PATH/tests/simpletest/expectation.php line 246]

@robocoder
Copy link
Contributor Author

(In [2220]) refs #1378

@robocoder
Copy link
Contributor Author

(In [2221]) refs #1378 - fix assert typos

@robocoder
Copy link
Contributor Author

(In [2222]) refs #1378

@robocoder
Copy link
Contributor Author

(In [2224]) refs #1378

@robocoder
Copy link
Contributor Author

Unable to reproduce the "Call to a member function getColumn() on a non-object in /PATH/core/DataTable/Filter/Sort.php on line 120" error, selecting days and/or periods with/without visits.

@robocoder
Copy link
Contributor Author

(In [2225]) refs #1378 - check return value from current() for failure

@robocoder
Copy link
Contributor Author

(In [2226]) fixes #1378

@robocoder
Copy link
Contributor Author

Typo in last commit... meant this ticket #1387.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

1 participant