Opened 4 years ago

Closed 3 years ago

#1382 closed Bug (fixed)

Sites Manager and Users Manager - Save Confusion

Reported by: vipsoft Owned by: matt
Priority: major Milestone: Piwik 1.2
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description (last modified by matt)

Usability issue

From Twitter: @OlegLeontiev: #bug in @piwik - once set TimeZone is not editable through AdminPanel. Although it allows editing actions, the changes're not commited

Change History (14)

comment:1 Changed 4 years ago by matt (mattab)

  • Resolution set to invalid
  • Status changed from new to closed

could you verify this? I couldn't reproduce.

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Component changed from Core to UI (templates, javascript)
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from Problem with timezone change to Sites Manager - Save Confusion

No, but I suspect this is because he used the big "Save" button (under Global Website Settings) instead of the clicking on the green checkmark. This is a small usability issue.

Propose we add a tooltip to the green checkmark and a "Save" button next to (or below) "Add a new website".

comment:3 Changed 4 years ago by vipsoft (robocoder)

Also, noticed that you can have multiple rows in edit state, but saving applies only to that one row, and refreshes the entire page (losing any other unsaved changes).

comment:4 Changed 4 years ago by vipsoft (robocoder)

(In [2219]) refs #1382 - add tooltips to ok.png and remove.png when in edit state

comment:5 Changed 4 years ago by vipsoft (robocoder)

  • Status changed from reopened to new

comment:6 Changed 4 years ago by matt (mattab)

To avoid users making several changes in several websites (or users), we could make it impossible to edit two rows at once. When a row is being edited, if the user clicks on another row, a javascript popup could ask 'Do you want to save your changes in the website properties before editing another website? Yes/Cancel'.

  • Clicking Yes would make the ajax request like when the OK button is clicked.
  • Clicking Cancel would restore the website properties as it was when the page was loaded.

This wouldn't fix the issue when a user edits a website and then clicks 'Save' in another section below though. Maybe the JS popup mentioned above could be displayed anytime the user focuses the mouse outside the row being edited (ie. when clicking another row, or when changing other settings on the page).

comment:7 follow-up: Changed 4 years ago by vipsoft (robocoder)

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Can we update the table after the ajax request without refreshing the page?

comment:8 in reply to: ↑ 7 Changed 4 years ago by matt (mattab)

Replying to vipsoft:

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Yes, maybe after v1 - even though it's nice to have more settings on the same page.

Can we update the table after the ajax request without refreshing the page?

Not currently..

comment:9 Changed 4 years ago by matt (mattab)

  • Milestone changed from 0 - Piwik 0.6.5 to Features requests - after Piwik 1.0

It would be simple yet useful to have a function that sets a flag when something has been updated in the table, and then warn users that he might lose changes if he doesn't save and click away in another cell of focuses outside the table.

comment:10 Changed 4 years ago by matt (mattab)

  • Description modified (diff)
  • Summary changed from Sites Manager - Save Confusion to Sites Manager and Users Manager - Save Confusion

comment:11 Changed 3 years ago by matt (mattab)

  • Description modified (diff)

Maybe we could display a big button at the bottom left of the cell as well as on the right?

comment:12 Changed 3 years ago by matt (mattab)

  • Milestone changed from Features requests to Piwik 1.x
  • Priority changed from normal to major

comment:13 Changed 3 years ago by matt (mattab)

  • Milestone changed from 1.x - Piwik 1.x to 1.2 Piwik 1.2
  • Owner set to matt

comment:14 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3663]) Fixes #1382

  • now preventing editing 2 rows at once
  • adding large SAVE button below the name on the left of the table (+ Cancel link which refreshes pages)

Fixes #1980

  • simplifying admin CSS, reusing same styles as PDF, Goals and datatables
  • deleting now unused icons & styles
Note: See TracTickets for help on using tickets.