Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Manager and Users Manager - Save Confusion #1382

Closed
robocoder opened this issue May 25, 2010 · 10 comments
Closed

Sites Manager and Users Manager - Save Confusion #1382

robocoder opened this issue May 25, 2010 · 10 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

Usability issue

From Twitter:@OlegLeontiev:#bugin@piwik-oncesetTimeZoneisnoteditablethroughAdminPanel.Althoughitallowseditingactions,thechanges'renotcommited

@mattab
Copy link
Member

mattab commented May 27, 2010

could you verify this? I couldn't reproduce.

@robocoder
Copy link
Contributor Author

No, but I suspect this is because he used the big "Save" button (under Global Website Settings) instead of the clicking on the green checkmark. This is a small usability issue.

Propose we add a tooltip to the green checkmark and a "Save" button next to (or below) "Add a new website".

@robocoder
Copy link
Contributor Author

Also, noticed that you can have multiple rows in edit state, but saving applies only to that one row, and refreshes the entire page (losing any other unsaved changes).

@robocoder
Copy link
Contributor Author

(In [2219]) refs #1382 - add tooltips to ok.png and remove.png when in edit state

@mattab
Copy link
Member

mattab commented May 27, 2010

To avoid users making several changes in several websites (or users), we could make it impossible to edit two rows at once. When a row is being edited, if the user clicks on another row, a javascript popup could ask 'Do you want to save your changes in the website properties before editing another website? Yes/Cancel'.

  • Clicking Yes would make the ajax request like when the OK button is clicked.
  • Clicking Cancel would restore the website properties as it was when the page was loaded.

This wouldn't fix the issue when a user edits a website and then clicks 'Save' in another section below though. Maybe the JS popup mentioned above could be displayed anytime the user focuses the mouse outside the row being edited (ie. when clicking another row, or when changing other settings on the page).

@robocoder
Copy link
Contributor Author

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Can we update the table after the ajax request without refreshing the page?

@mattab
Copy link
Member

mattab commented May 27, 2010

Replying to vipsoft:

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Yes, maybe after v1 - even though it's nice to have more settings on the same page.

Can we update the table after the ajax request without refreshing the page?

Not currently..

@mattab
Copy link
Member

mattab commented Jul 22, 2010

It would be simple yet useful to have a function that sets a flag when something has been updated in the table, and then warn users that he might lose changes if he doesn't save and click away in another cell of focuses outside the table.

@mattab
Copy link
Member

mattab commented Nov 23, 2010

Maybe we could display a big button at the bottom left of the cell as well as on the right?

@mattab
Copy link
Member

mattab commented Jan 7, 2011

(In [3663]) Fixes #1382

  • now preventing editing 2 rows at once
  • adding large SAVE button below the name on the left of the table (+ Cancel link which refreshes pages)

Fixes #1980

  • simplifying admin CSS, reusing same styles as PDF, Goals and datatables
  • deleting now unused icons & styles

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants