Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize static assets (stylesheets, scripts, images) #1385

Closed
robocoder opened this issue May 27, 2010 · 4 comments
Closed

Reorganize static assets (stylesheets, scripts, images) #1385

robocoder opened this issue May 27, 2010 · 4 comments
Assignees
@robocoder
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
1.x

Comments

@robocoder
Copy link
Contributor

Relocate static assets (e.g., images, stylesheets, and scripts) to the plugin's top level folder, instead of in templates, e.g.,

plugins/NAME/css/
plugins/NAME/js/
plugins/NAME/images/
plugins/NAME/templates/

Similarly, move themes/default into a core plugin, e.g.,

plugins/CoreTheme/css/
plugins/CoreTheme/js/
plugins/CoreTheme/images/
plugins/CoreTheme/templates/

Rationale:
@robocoder
Copy link
Contributor Author

CoreTheme may be a misnomer as it isn't a self-contained theme. Let's go with CoreUI instead.

@mattab
Copy link
Member

mattab commented Sep 23, 2010

Maybe this could be bundled in the main CoreHome plugin? It would be good to minimize number of plugins :)

@robocoder
Copy link
Contributor Author

(In [3187]) refs #1385

@mattab
Copy link
Member

mattab commented Apr 28, 2011

Moving requirements into "theming" as it is still to be defined exactly how it's going to work (or if we will implement it at all, probably just a simpler version) #177

@robocoder robocoder added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
@mattab mattab mentioned this issue Nov 24, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
2 participants
@mattab @robocoder