Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#1388 closed Bug (fixed)

Page URLs should not record the hash part of the URL

Reported by: matt Owned by: matt
Priority: major Milestone: Piwik 1.2
Component: Core Keywords:
Cc: Sensitive: no

Description

See in the demo Page URLs report. Since 0.6.2, entries are linked to the actual page URL. If you click on faq/plugins/ for example, you see that the page "index" links to http://piwik.org/faq/general/#faq_52

Instead, URLs should link to the canonical URL without the hash part. The hash must be removed at Tracker time.

Note: the tracker must still receive the hash, for future uses (eg. detect campaign parameters in the hash), but the php code must discard it.

Change History (9)

comment:1 Changed 4 years ago by SteveG (sgiehl)

I guess for some pages it would even make sense to display those hash parts in the Page Urls report. Most Ajax-driven websites aren't changing the url often. In most cases only the hash part changes for history. Facebook might be a good example for that. Maybe it might be the best solution to make that behaviour configurable.

comment:2 Changed 4 years ago by matt (mattab)

  • Owner set to matt

comment:3 Changed 4 years ago by matt (mattab)

  • Milestone changed from 3 - Piwik 0.9 - Surviving The Wild to 5 - Piwik 1.1

comment:4 Changed 3 years ago by matt (mattab)

  • Milestone changed from 1.1 - Piwik 1.1 to Piwik 1.x

comment:5 Changed 3 years ago by matt (mattab)

Good point Steve, I think this should be an option at the javascript level, ie.

setDisallowHashTags()

by default, we would record the hash tag, users could disable it.

comment:6 Changed 3 years ago by vipsoft (robocoder)

I thought this looked familiar. #1180

comment:7 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3687]) fixes #1388

comment:8 Changed 3 years ago by vipsoft (robocoder)

  • Milestone changed from 1.x - Piwik 1.x to 1.2 Piwik 1.2

comment:9 Changed 3 years ago by matt (mattab)

Cool, later we will want to have the setAllowAnchor, because some campaign parameters are sometimes set in the hash tag, but we can do it later (also requires change in piwik.php to discard the hash tag bit in all cases after campaign parameters were parsed)

Note: See TracTickets for help on using tickets.