Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page URLs should not record the hash part of the URL #1388

Closed
mattab opened this issue May 28, 2010 · 5 comments
Closed

Page URLs should not record the hash part of the URL #1388

mattab opened this issue May 28, 2010 · 5 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.2

Comments

@mattab
Copy link
Member

mattab commented May 28, 2010

See in the demo Page URLs report. Since 0.6.2, entries are linked to the actual page URL. If you click on faq/plugins/ for example, you see that the page "index" links to http://piwik.org/faq/general/#faq_52

Instead, URLs should link to the canonical URL without the hash part. The hash must be removed at Tracker time.

Note: the tracker must still receive the hash, for future uses (eg. detect campaign parameters in the hash), but the php code must discard it.
@sgiehl
Copy link
Member

sgiehl commented Jul 24, 2010

I guess for some pages it would even make sense to display those hash parts in the Page Urls report. Most Ajax-driven websites aren't changing the url often. In most cases only the hash part changes for history. Facebook might be a good example for that. Maybe it might be the best solution to make that behaviour configurable.

@mattab
Copy link
Member Author

mattab commented Jan 10, 2011

Good point Steve, I think this should be an option at the javascript level, ie.

setDisallowHashTags()

by default, we would record the hash tag, users could disable it.

@robocoder
Copy link
Contributor

I thought this looked familiar. #1180

@robocoder
Copy link
Contributor

(In [3687]) fixes #1388

@mattab
Copy link
Member Author

mattab commented Jan 10, 2011

Cool, later we will want to have the setAllowAnchor, because some campaign parameters are sometimes set in the hash tag, but we can do it later (also requires change in piwik.php to discard the hash tag bit in all cases after campaign parameters were parsed)

@mattab mattab added this to the Piwik 1.2 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
@robocoder robocoder mentioned this issue Sep 3, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@mattab @robocoder @sgiehl