New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: feedback popup content is loaded by default #1425
Comments
I'm not sure I can fix this. As I recall, when I updated to using jQuery UI, the iframe approach was broken cross-browser; hence the current non-iframe approach. Perhaps SteveG or JulienM could take a stab at it (with a fresh pair of eyes). |
Isn't it enough to change the feedback.js like this?
|
Close, but missing the image showing that the content is loading. Before it used to ajax load on click (rather than during init) like you suggest, but we need some image that shows that stuff is loading. Alternatively we can display the standard 'Loading data...' (call to smarty {ajaxLoadingDiv id=feedbackLoading} eg.) |
Well, I see.
|
Any further suggestions or shall I commit that change to trunk? |
assuming you've tested it, looks good to me |
(What was I thinking?) Good work. Check it in. |
(In [2398]) fixes #1425 load feedback popup only if required |
The feedback popup content is loaded by default.
Instead, the Feedback plugin controller should be called only when the 'Give us feedback!' link is clicked.
Fixing this will save 1 http request (see request).
The text was updated successfully, but these errors were encountered: