Opened 4 years ago

Closed 4 years ago

#1433 closed Bug (fixed)

ArchiveProcessing unit test failing

Reported by: vipsoft Owned by: vipsoft
Priority: normal Milestone: Piwik 0.6.3
Component: Core Keywords:
Cc: Sensitive: no

Description

I was looking into why a failed unit test doesn't fail the build and I noticed that we have been failing a unit test on bamboo.openx.org for a while now (circa r2091).

<span class="fail">Fail</span>: ../tests/core/ArchiveProcessing.test.php -&gt; Test_Piwik_ArchiveProcessing -&gt; test_init_today -&gt; Equal expectation fails because [Integer: 1276803074] differs from [Integer: 0] by 1276803074 at line 107

Change History (8)

comment:1 Changed 4 years ago by matt (mattab)

interesting, the test is not failing on my box. Definitely something to investigate

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to vipsoft

It's failing on my ci server too, but not when running the test directly in the browser. Difference is php-cli vs mod_php. I'll take a look at the phpinfo() differences.

comment:3 Changed 4 years ago by vipsoft (robocoder)

(In [2329]) refs #1433 - refactoring

comment:4 Changed 4 years ago by vipsoft (robocoder)

Ok. It was due to these changes.

!isArchivingEnabled() isn't functionally equivalent to isBrowserTriggerArchivingEnabled() because isArchivingEnabled() has a check for isPhpCliMode(). This is what trips up the unit test on the continuous integration server (it uses php-cli to run the unit tests).

comment:5 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2331]) fixes #1433

comment:6 Changed 4 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

reopening as I need to check something

comment:8 Changed 4 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.