Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal Error in archiver with Turkish locale #1437

Closed
anonymous-matomo-user opened this issue Jun 21, 2010 · 4 comments
Closed

Fatal Error in archiver with Turkish locale #1437

anonymous-matomo-user opened this issue Jun 21, 2010 · 4 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
0.6.3

Comments

@anonymous-matomo-user
Copy link

Hi,
I'm using Piwik on a system with tr_TR.UTF-8 locale and this error shows up when running archiver:

Fatal error: Class 'Piwik_Db_Adapter_MysqlI' not found in /my_path_to_piwik/piwik/core/Db/Adapter.php on line 41

And that line is:
return 'Piwik_Db_Adapter_' . str_replace(' ', '', ucwords(str_replace('', ' ', strtolower($adapterName))));

Problem is strtolower doesn't lower MysqlI properly, it should lower to "mysqli" but in Turkish locale lower letter for "I" is "" so that makes "mysql". I think you should use a locale independent (or working only in latin1 locale) strtolower here, but I don't know what is the proper way to do that in php.

I run archiver with LC_ALL=C for a workaround and it works fine that way.
@robocoder
Copy link
Contributor

Interesting.

@mattab
Copy link
Member

mattab commented Jun 21, 2010

interesting indeed.. If strtolower fails, other logic/algorithm will fail too.
For example if we add a 'renderer' with a 'i' letter in the name, the factory will fail.

@robocoder
Copy link
Contributor

Ok, I was able to reproduce after I ran locale-gen (and logged out and back in).

@robocoder
Copy link
Contributor

(In [2327]) quick fixes #1437 - setlocale(LC_CTYPE, '') so strtolower(), strtoupper(), ucfirst(), and ucwords() aren't affected by locale

In the future, we might consider implementing a thread-safe alternative to using setlocale() given this warning:

The locale information is maintained per process, not per thread. If you are running PHP on a multithreaded server API like IIS or Apache on Windows, you may experience sudden changes in locale settings while a script is running, though the script itself never called setlocale(). This happens due to other scripts running in different threads of the same process at the same time, changing the process-wide locale using setlocale().

Reference: http://php.net/setlocale

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.6.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
0.6.3
Development

No branches or pull requests
3 participants
@mattab @robocoder @anonymous-matomo-user