Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1442 closed Bug (fixed)

Replace Html Quickform for GPL compatibility

Reported by: vipsoft Owned by: vipsoft
Priority: major Milestone: Piwik 0.6.4
Component: Core Keywords:
Cc: Sensitive: no

Description

Follow-up to #1243: the current version of Piwik has been rejected from directory.fsf.org due to license issues:

  • license files are missing or incomplete (which we' will need to advise upstream) for some third-party components/libraries
  • the PEAR package, Html/Quickform is licensed under PHP 3.01 license and is GPL incompatible; propose we migrate to Zend_Form

Change History (25)

comment:1 follow-up: Changed 4 years ago by matt (mattab)

  • Milestone changed from 0 - Piwik 0.6.3 to Features requests - after Piwik 1.0

ok sounds good about moving to Zend_Form, but delaying

comment:2 Changed 4 years ago by vipsoft (robocoder)

Matt: did you write jquery.truncate.js? That file and UserAgentParser.php are missing license notices.

comment:3 Changed 4 years ago by matt (mattab)

yes I wrote both files

comment:4 Changed 4 years ago by vipsoft (robocoder)

So, MIT/GPL and LGPL, respectively?

comment:5 Changed 4 years ago by matt (mattab)

I would say both under BSD

comment:6 Changed 4 years ago by vipsoft (robocoder)

(In [2369]) refs #1442 - add BSD license text

comment:7 Changed 4 years ago by vipsoft (robocoder)

(In [2371]) refs #1442 - add missing license files per FSF review; remove uncompressed javascript folders; move jquery.tooltip and jquery.truncate to parent folder for consistency

comment:8 Changed 4 years ago by vipsoft (robocoder)

  • As noted in ./LEGALNOTICE, jquery.spy's license is unspecified. I have requested clarification from the developer.
  • Also, the copyright holder is unspecified from swfobject , and I have similarly requested clarification.
  • An alternative to Zend_Form may be HTML_QuickForm2 which is BSD licensed, but currently in alpha state (v0.4 released earlier this month).

comment:9 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to vipsoft

comment:11 Changed 4 years ago by vipsoft (robocoder)

(In [2388]) refs #1442 - rename Login forms for consistency with Installation forms; rename Piwik_Form to Piwik_QuickForm

comment:12 Changed 4 years ago by vipsoft (robocoder)

(In [2390]) refs #1442 - consistency in constructors

comment:13 Changed 4 years ago by vipsoft (robocoder)

(In [2415]) refs #1442 - update license info

comment:14 Changed 4 years ago by vipsoft (robocoder)

  • Submitted request to devs to re-license HTML_QuickForm, as that would be faster/easier than switching over to Zend_Form or HTML_QuickForm2.
  • Sent another email to Remy Sharp requesting clarification on jquery spy license.

comment:15 in reply to: ↑ 1 Changed 4 years ago by vipsoft (robocoder)

Not getting any love from the QF devs. Back to plan A.

comment:16 Changed 4 years ago by vipsoft (robocoder)

(In [2417]) refs #1442 - another license incompatibility; the latest version of the PEAR base system is BSD licensed, so will look into updating to that...

comment:17 Changed 4 years ago by vipsoft (robocoder)

(In [2418]) refs #1442 - update PEAR to latest version which is BSD licensed (and thus, GPL compatible)

comment:18 Changed 4 years ago by vipsoft (robocoder)

(In [2419]) refs #1442 - add license file to PEAR and some new dependencies; add "static" keyword to isError and raiseError as this throws notices with HTML_QuickForm

comment:19 Changed 4 years ago by vipsoft (robocoder)

(In [2428]) refs #1442 - discard Zend_Form -- too much overhead and rework; will port to QuickForm2

comment:20 Changed 4 years ago by vipsoft (robocoder)

jquery.spy is now MIT licensed.

I'll try to finish the QF2 port tonight.

comment:21 Changed 4 years ago by vipsoft (robocoder)

(In [2435]) refs #1442 - add HTML_Common2 and HTML_QuickForm2 - New BSD licensed

comment:22 Changed 4 years ago by vipsoft (robocoder)

In [2437]:

Synced up with PEAR svn repository revision 301028

comment:23 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2438]) fixes #1442 - all GPL license incompatibilities resolved

Live: Thanks to Remy Sharp, jquery.spy is now explicitly MIT licensed.
Installation: converted to use HTML_QuickForm2
Login: converted to use HTML_QuickForm2

comment:24 Changed 4 years ago by vipsoft (robocoder)

  • Milestone changed from Features requests - after Piwik 1.0 to 0 - Piwik 0.6.4

comment:25 Changed 4 years ago by vipsoft (robocoder)

(In [2506]) refs #1442 - fix typo in prefix

Note: See TracTickets for help on using tickets.