Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Html Quickform for GPL compatibility #1442

Closed
robocoder opened this issue Jun 23, 2010 · 23 comments
Closed

Replace Html Quickform for GPL compatibility #1442

robocoder opened this issue Jun 23, 2010 · 23 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

Follow-up to #1243: the current version of Piwik has been rejected from directory.fsf.org due to license issues:

  • license files are missing or incomplete (which we' will need to advise upstream) for some third-party components/libraries
  • the PEAR package, Html/Quickform is licensed under PHP 3.01 license and is GPL incompatible; propose we migrate to Zend_Form
@mattab
Copy link
Member

mattab commented Jun 23, 2010

ok sounds good about moving to Zend_Form, but delaying

@robocoder
Copy link
Contributor Author

Matt: did you write jquery.truncate.js? That file and UserAgentParser.php are missing license notices.

@mattab
Copy link
Member

mattab commented Jun 23, 2010

yes I wrote both files

@robocoder
Copy link
Contributor Author

So, MIT/GPL and LGPL, respectively?

@mattab
Copy link
Member

mattab commented Jun 23, 2010

I would say both under BSD

@robocoder
Copy link
Contributor Author

(In [2369]) refs #1442 - add BSD license text

@robocoder
Copy link
Contributor Author

(In [2371]) refs #1442 - add missing license files per FSF review; remove uncompressed javascript folders; move jquery.tooltip and jquery.truncate to parent folder for consistency

@robocoder
Copy link
Contributor Author

  • As noted in ./LEGALNOTICE, jquery.spy's license is unspecified. I have requested clarification from the developer.
  • Also, the copyright holder is unspecified from swfobject , and I have similarly requested clarification.
  • An alternative to Zend_Form may be HTML_QuickForm2 which is BSD licensed, but currently in alpha state (v0.4 released earlier this month).

@robocoder
Copy link
Contributor Author

(In [2385]) refs #1442

@robocoder
Copy link
Contributor Author

(In [2388]) refs #1442 - rename Login forms for consistency with Installation forms; rename Piwik_Form to Piwik_QuickForm

@robocoder
Copy link
Contributor Author

(In [2390]) refs #1442 - consistency in constructors

@robocoder
Copy link
Contributor Author

(In [2415]) refs #1442 - update license info

@robocoder
Copy link
Contributor Author

  • Submitted request to devs to re-license HTML_QuickForm, as that would be faster/easier than switching over to Zend_Form or HTML_QuickForm2.
  • Sent another email to Remy Sharp requesting clarification on jquery spy license.

@robocoder
Copy link
Contributor Author

Not getting any love from the QF devs. Back to plan A.

@robocoder
Copy link
Contributor Author

(In [2417]) refs #1442 - another license incompatibility; the latest version of the PEAR base system is BSD licensed, so will look into updating to that...

@robocoder
Copy link
Contributor Author

(In [2418]) refs #1442 - update PEAR to latest version which is BSD licensed (and thus, GPL compatible)

@robocoder
Copy link
Contributor Author

(In [2419]) refs #1442 - add license file to PEAR and some new dependencies; add "static" keyword to isError and raiseError as this throws notices with HTML_QuickForm

@robocoder
Copy link
Contributor Author

(In [2428]) refs #1442 - discard Zend_Form -- too much overhead and rework; will port to QuickForm2

@robocoder
Copy link
Contributor Author

jquery.spy is now MIT licensed.

I'll try to finish the QF2 port tonight.

@robocoder
Copy link
Contributor Author

(In [2435]) refs #1442 - add HTML_Common2 and HTML_QuickForm2 - New BSD licensed

@robocoder
Copy link
Contributor Author

In [2437]:

Synced up with PEAR svn repository revision 301028

    * add HTML_QuickForm2_Renderer_Smarty
    * comment out require_once
    * let autoloaders try loading class first -  http://pear.php.net/bugs/bug.php?id=17568
    * HTML_QuickForm_Node -  http://pear.php.net/bugs/17557 

@robocoder
Copy link
Contributor Author

(In [2438]) fixes #1442 - all GPL license incompatibilities resolved

Live: Thanks to Remy Sharp, jquery.spy is now explicitly MIT licensed.
Installation: converted to use HTML_QuickForm2
Login: converted to use HTML_QuickForm2

@robocoder
Copy link
Contributor Author

(In [2506]) refs #1442 - fix typo in prefix

@robocoder robocoder added this to the Piwik 0.6.4 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants