New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArchiveProcessing: timezone issues #1458
Comments
And now at 01:04 EST (05:04 UTC), the unit tests are passing again. So there's a timezone issue here. |
Rolling into #818 |
Re-opening as a separate issue. |
Still fails but it looks like it may only be a problem between 20:00 EDT and 21:00 EDT. A bug involving daylight saving time, perhaps? I'll have to debug on another box where I can mess around with the system time... |
The ArchiveProcessing tests fail when run between 8 PM and 9 PM EDT. During this hour, I presume no archiving occurs because getMinTimeArchivedProcessed() is > time(). |
Because this is daylight saving time, this corresponds to UTC+0 to UTC+1. In this unit test, the timezone is set to UTC-1. |
(In [2694]) fixes #1458 |
I think the fix in [2694] might be wrong. The root problem appears to be that $this->startTimestampUTC is already for the next day (based on UTC instead of the site's timezone). |
(In [2926]) refs #1458 - add date test for America/Vancouver (PST/PDT) |
(In [2927]) refs #1458 - cache current time so we avoid the false build failure |
With Piwik 0.9 for a site with 15 visits per day, I have stats only for the date range "day", so there's no data for "week", "month" and "year". If you need access to the Piwik installation, just ask. |
See also #1631 |
(In [3022]) refs #1458 - add conversion test |
(In [3025]) refs #1458 - fix indentation |
In http://forum.piwik.org/index.php?s=&showtopic=13471&view=findpost&p=61141, it appears we also have an issue with timezone adjustment in core/Controller.php. |
(In [3064]) refs #1458 - fixes maxDate issue reported in http://forum.piwik.org/index.php?showtopic=13471 (this is correct in core/Controller.php) |
Anthon, would r3064 fix all problems reported in http://forum.piwik.org/index.php?showtopic=13471&st=20&start=20 ? If so, maybe we can post patch there and ask users to try it out? thx :) |
r3064, just fixes the MultiSites datepicker, so users can't select a future day. |
See unit failure in http://qa.piwik.org:8080/hudson/job/Piwik/498/ -- 09/30 6:42 pm.
|
(In [3227]) refs #1458 - fix unit test failure per comment:21 |
Marking as fixed for now. I've tested this as much as I could (messing with my system time and inspecting the archive tables). |
Hang on... I reverted the hack in [2694], and I'm getting weird results in test_init_today. I also added for Europe/Paris and America/Toronto. It looks like internally, there's a timeshifting bug back to UTC-4. I get errors for:
|
appears to be broken again in trunk |
Ah... [3575]. I'll attach the test script and output for your reference matt. Maybe you can fix this regression. |
Attachment: Bash script. Run it from the tests/core folder. Disable ntp (or other date/time synchronization daemons). |
Attachment: unit test results |
Also failing in the CI server. http://qa.piwik.org:8080/hudson/job/Piwik/852/consoleText |
(In [3591]) Fixes #1458 Hopefully this fixes it... it should be correct this time |
Just started appearing now that it's currently 20:34 EST (now 00:34 UTC).
The text was updated successfully, but these errors were encountered: