Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate: URL irregularities #1462

Closed
robocoder opened this issue Jul 4, 2010 · 3 comments
Closed

Investigate: URL irregularities #1462

robocoder opened this issue Jul 4, 2010 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@robocoder
Copy link
Contributor

Do we properly handle:

  • malformed URLs, eg http:domain and http:/domain (which are auto-corrected by some browsers)
  • trailing period on tld, eg http://domain.tld./path
@mattab
Copy link
Member

mattab commented Jul 12, 2010

To test this, I would recommend modifying one of the Main.test.php tracker setup and call setUrl() with the malformed URLs.

@mattab
Copy link
Member

mattab commented Jul 22, 2010

If we change this, we will have several formats of URLs coming in from several versions of the Tracker API clients (http://piwik.org/docs/tracking-api/)

Goal of this ticket would be to not trigger the mod_security error when a URL is found in a GET param. dreamhost (or is it bluehost) can disable the mod_security on demand.

@mattab
Copy link
Member

mattab commented Jan 17, 2011

I tried with the patch:

### Eclipse Workspace Patch 1.0
#P trunk
Index: tests/integration/Main.test.php
===================================================================
--- tests/integration/Main.test.php (revision 3762)
+++ tests/integration/Main.test.php (working copy)
@@ -258,7 +258,7 @@
        $visitorB->setForceVisitDateTime(Piwik_Date::factory($dateTime)->addHour(1)->getDatetime());
         $visitorB->setUrlReferer( '' );
        $visitorB->setUserAgent('Opera/9.63 (Windows NT 5.1; U; en) Presto/2.1.1');
-       $visitorB->setUrl('http://example.org/products');
+       $visitorB->setUrl('http:/example.org/products');
        $this->checkResponse($visitorB->doTrackPageView('first page view'));

        // -
@@ -277,7 +277,7 @@
         $visitorAsite2 = $this->getTracker($idSite2, Piwik_Date::factory($dateTime)->addHour(24)->getDatetime(), $defaultInit = true);
         $visitorAsite2->setUserAgent('Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0;)');
         $visitorAsite2->setUrlReferer('http://only-homepage-referer.com/');
-        $visitorAsite2->setUrl('http://example2.com/home');
+        $visitorAsite2->setUrl('http://example2.com./home');
         $this->checkResponse($visitorAsite2->doTrackPageView('Website 2 page view'));

         // Returning visitor on Idsite 2 1 day later, one page view, with chinese referer

and I see that

  • malformed URL: they are tracked, but are split by the / separator after http: and also split by the first / after hostname, instead of showing the first category by default.
  • extra dot in domain name handled correctly, ie. tracked as URL for the requested page independently of whether the dot is in there or not

I don't think we need to handle malformed URL since it could show a bug in the website (ie. wrong link somewhere) or on a partner/campaign href.

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@user287435 user287435 mentioned this issue Feb 4, 2023
Open
@stefan-thothmind stefan-thothmind mentioned this issue Feb 10, 2023
Open
Open
@AkshayraviC09YC47 AkshayraviC09YC47 mentioned this issue Jun 7, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder