Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1469 closed New feature (fixed)

File integrity check errors when files not uploaded in binary mode

Reported by: vipsoft Owned by: vipsoft
Priority: normal Milestone: Piwik 0.6.4
Component: Core Keywords:
Cc: Sensitive: no

Description

Pseudo-code:

already_reported = false
...
if (fails filelength check) {
    message = 'File length mismatch'
    if (! already_reported) {
        read file
        convert CR LF to LF
        if (md5 sum passes) {
            message = 'File length mismatch.  Please re-upload your files using BINARY mode.'
            already_reported = true
        }
    }
    messages[] = message
}

Change History (4)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Owner set to vipsoft

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2591]) fixes #1469

comment:4 Changed 4 years ago by vipsoft (robocoder)

(In [2622]) refs #1469 - performance improvement: check converted length vs expected, before hashing

Note: See TracTickets for help on using tickets.