Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File integrity check errors when files not uploaded in binary mode #1469

Closed
robocoder opened this issue Jul 8, 2010 · 3 comments
Closed
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@robocoder
Copy link
Contributor

Pseudo-code:

already_reported = false
...
if (fails filelength check) {
    message = 'File length mismatch'
    if (! already_reported) {
        read file
        convert CR LF to LF
        if (md5 sum passes) {
            message = 'File length mismatch.  Please re-upload your files using BINARY mode.'
            already_reported = true
        }
    }
    messages[] = message
}
@robocoder
Copy link
Contributor Author

(In [2591]) fixes #1469

@robocoder
Copy link
Contributor Author

(In [2592]) refs #1469

@robocoder
Copy link
Contributor Author

(In [2622]) refs #1469 - performance improvement: check converted length vs expected, before hashing

@robocoder robocoder added this to the Piwik 0.6.4 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

1 participant