Opened 4 years ago

Closed 4 years ago

#1479 closed Bug (fixed)

SEO plugin doesn't catch errors.

Reported by: halfdan Owned by:
Priority: major Milestone: Piwik 0.6.4
Component: Core Keywords:
Cc: Sensitive: no

Description

The SEO plugin (got it on a regular install) isn't properly handling errors. Yesterday I did get "Cannot resolve host who.is", today I'm having a "curl_exec: connect() timed out" (see attachment).

Attachments (1)

SEOplugin.png (2.7 KB) - added by halfdan 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by halfdan

comment:1 Changed 4 years ago by vipsoft (robocoder)

It could be a slow DNS resolve. Try increasing the timeout in RankChecker.php from 5 to say 30. Look for the line that calls Piwik_Http::sendHttpRequest().

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2507]) fixes #1479 - sendHttpRequest() can throw exception, so we must try...catch; also fix the formatting to conform to style guidelines; update third-party licensing doc

Note: See TracTickets for help on using tickets.