Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO plugin doesn't catch errors. #1479

Closed
halfdan opened this issue Jul 15, 2010 · 3 comments
Closed

SEO plugin doesn't catch errors. #1479

halfdan opened this issue Jul 15, 2010 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@halfdan
Copy link
Member

halfdan commented Jul 15, 2010

The SEO plugin (got it on a regular install) isn't properly handling errors. Yesterday I did get "Cannot resolve host who.is", today I'm having a "curl_exec: connect() timed out" (see attachment).

@halfdan
Copy link
Member Author

halfdan commented Jul 15, 2010

Attachment:
SEOplugin.png

@robocoder
Copy link
Contributor

It could be a slow DNS resolve. Try increasing the timeout in RankChecker.php from 5 to say 30. Look for the line that calls Piwik_Http::sendHttpRequest().

@robocoder
Copy link
Contributor

(In [2507]) fixes #1479 - sendHttpRequest() can throw exception, so we must try...catch; also fix the formatting to conform to style guidelines; update third-party licensing doc

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants