Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1498 closed Bug (fixed)

upgradephp - unit test failures

Reported by: vipsoft Owned by:
Priority: low Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

If the json extension is disabled (e.g., --disable-json) or missing (e.g., for php 5.1.x, json is an optional PECL extension), the unit tests fail due to differences in the compatibility function. (One of the failures may be a bug.)

Attachments (1)

all_tests.html (7.2 KB) - added by vipsoft 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by vipsoft (robocoder)

comment:1 Changed 4 years ago by matt (mattab)

  • Milestone changed from 0 - Piwik 0.6.5 to Features requests - after Piwik 1.0
  • Priority changed from normal to low

It looks like all tests but 1 are failign because of encoding differences of utf8 characters, which is OK

one bug however fails because numeric indexes are not exported in the array, as expected

string(150) "{"Limitation":["Multi dimensional arrays is only supported by format=JSON","Known limitation"],"Second Dimension":[true,false,1,0,152,"test",["end"]]}"

string(155) "{"Limitation":["Multi dimensional arrays is only supported by format=JSON","Known limitation"],"Second Dimension":[true,false,1,0,152,"test",{"42":"end"}]}"

very low priority bug as all API arrays should never rely on numeric indexes anyway. vote for wontfix...

comment:2 Changed 4 years ago by vipsoft (robocoder)

We'll have to figure out a workaround. When Hudson is fully configured, the php 5.1.x builds will be continuously failing as a result, and at the moment, Piwik claims to still support php 5.1.3 and above.

comment:3 Changed 4 years ago by matt (mattab)

for the numeric index, i'll remove this test case from the array.

can you think of a solution to encoding issues? otherwise, we can hijack these tests for this specific build ;)

comment:4 Changed 4 years ago by matt (mattab)

because don't get me wrong, I want hudson sunny before 1.0 :)

comment:5 Changed 4 years ago by vipsoft (robocoder)

  • Milestone changed from Features requests 1.x or 2.x to 1.1 - Piwik 1.1

comment:6 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3230]) fixes #1498

comment:7 Changed 4 years ago by vipsoft (robocoder)

(In [3236]) refs #1498 - really fix it this time

Note: See TracTickets for help on using tickets.