Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow pre-1.0 to upgrade past 1.0. #1521

Closed
robocoder opened this issue Jul 28, 2010 · 2 comments
Closed

Don't allow pre-1.0 to upgrade past 1.0. #1521

robocoder opened this issue Jul 28, 2010 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

For the 1.0 release, the response from:

http://api.piwik.org/1.0/getLatestVersion

should be frozen as 1.0.

The url in core/UpdateCheck.php should change to:

http://api.piwik.org/2.0/getLatestVersion

This will allow us to:

  • clean up some of the code (e.g., remove any deprecated methods, obsolete core/Updates/* files)
  • add expected file length (of latest.zip) and sha1 hash to response (compat buster)
  • reduce end-user support for users upgrading from 0.x to 1.x, i.e., we can focus on 1.0 to 1.x
@mattab
Copy link
Member

mattab commented Jul 29, 2010

sounds like a good idea,
but I vote to do this in 1.x first release (it doesn't matter when we do this I think?)

@robocoder
Copy link
Contributor Author

1.0 is an arbitrary cut-off. Whatever version we do this becomes the cut-off as it requires a change in core/UpdateCheck.php and on the server.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants