Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1545 closed Task (fixed)

Adapt styling of chart and map tooltips to the new UI design

Reported by: greg Owned by:
Priority: low Milestone: Piwik 0.9 - Surviving The Wild
Component: UI - UX (AngularJS, twig, less) Keywords: charts, tooltip
Cc: Sensitive: no

Description

I would like to adapt the appearance of the chart tooltips to the new UI design. This should be possible by adding simple statements to the chart-api call (see examples).

In the attached screenshot you can see my suggestion for the new tooltips.

Attachments (2)

tooltips.png (6.3 KB) - added by greg 4 years ago.
tooltips_better.png (46.6 KB) - added by greg 4 years ago.
this is rendered using the patched version of open-flash-charts.swf and an updated version of the map swf. the tooltips integrate nicely into the Piwik UI

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by greg (gka)

comment:1 Changed 4 years ago by greg (gka)

I just checked if it is possible to customize the tooltip as would like to. Sadly, it's not possible to insert bold text inside of the tooltips body text. It is also impossible to change the text font.

After looking at the source code of open-flash-charts I instantly found the code that limits the customization. The font name "Verdana" is hardcoded in the source. Fortunately it wasn't very difficult to fix this "bug" and the patched version is now committed to the Open Flash Chart tracker at sourceforge. I tested my changes and it works very well. Surprisingly the file size of the open-flash-chart.swf has also reduced from 269kb to 172kb after rebuilding it with the current Flex SDK.

I hope John Glazebrook includes my patch since I don't want to maintain a fork ;)

Changed 4 years ago by greg (gka)

this is rendered using the patched version of open-flash-charts.swf and an updated version of the map swf. the tooltips integrate nicely into the Piwik UI

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Milestone set to 3 - Piwik 0.9 - Surviving The Wild

I've set the milestone only because it wasn't set.

We may have to discuss and defer to a later target milestone.

We generally don't want to maintain forks of third-party components/libraries. We do make exceptions though, eg for php version compatibility
and bug fixes (which we report upstream).

At this point, OFC's future appears unclear -- it hasn't seen a new release in a year; ditto for the ofcgwt and dz forks.

comment:3 Changed 4 years ago by matt (mattab)

Anthon, OFC is dead: http://forums.openflashchart.com/viewtopic.php?f=3&t=2091&p=6457#p6601

I don't see a problem forking considering

  • Greg is a flash specialist
  • We are happy with current features of OFC (ie. we are not waiting for bug fixes or other new features from them)
  • Greg has already done the change :-)

Greg, how should we proceed from there? Looks good to commit to me.

comment:4 Changed 4 years ago by vipsoft (robocoder)

In that case, we can either fork or contribute the patch to another fork (http://forums.openflashchart.com/viewtopic.php?f=5&t=2344).

For the record, these aren't blockers, but we have encountered OFC bugs:

http://forums.openflashchart.com/download/file.php

comment:5 Changed 4 years ago by greg (gka)

Since there is no ongoing development on OFC, I suggest we should fork it in order maintain at least a stable and bug-free version that we can use for Piwik until the time is right to switch to SVG charts. Don't think that will hurt anybody. Patching OFC is easy since it is now written in pure AS3 and the code structure is reasonably plausible.

I'll put the fork to svn/open-flash-charts/trunk if that's ok with you. Each commit will be commented so applying the patches to other forks should be easy.

comment:6 Changed 4 years ago by vipsoft (robocoder)

Ok. (There's a post by etw that OFC trunk is buggy, so we should fork from the Lug Wyrm Charmer release.)

comment:7 Changed 4 years ago by greg (gka)

  • Resolution set to fixed
  • Status changed from new to closed

(In [2857]) updated tooltip appearance, party fixes #1545

comment:8 Changed 4 years ago by greg (gka)

(In [2858]) fixes #1545

  • updated tooltip colors
  • updated chart tooltips (setting values in bold text)
  • copied open-flash-chart.swf (OFC-patch #001)
  • copied PiwikMap.swf

comment:9 Changed 4 years ago by matt (mattab)

simple yet great UI improvement :) good stuff Greg!

Note: See TracTickets for help on using tickets.