Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive domain name matching #1578

Closed
robocoder opened this issue Aug 12, 2010 · 6 comments
Closed

Case-insensitive domain name matching #1578

robocoder opened this issue Aug 12, 2010 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

Use mb_strtolower() on the server side for referers, etc.

On the client, use JavaScript's .toLowerCase().

@robocoder
Copy link
Contributor Author

(In [2920]) refs #1578

@mattab
Copy link
Member

mattab commented Aug 15, 2010

I think it also includes the Tracker url matching, eg. in detectRefererDirectEntry() in Visit.php

@mattab
Copy link
Member

mattab commented Aug 15, 2010

@robocoder
Copy link
Contributor Author

And treat www.domain.com and domain.com as equivalent?

@mattab
Copy link
Member

mattab commented Aug 16, 2010

Replying to vipsoft:

And treat www.domain.com and domain.com as equivalent?

It would make sense I think

@mattab
Copy link
Member

mattab commented Mar 26, 2011

(In [4201]) Fixes #1578

@robocoder robocoder added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants