We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The response for SitesManager.updateSite is wrong. Calling it with an unknown idSite parameter results in
{"result":"success", "message":"ok"}
http://example.com/?module=API&idSite=124&format=JSON&token_auth=YOUR_TOKEN&method=SitesManager.updateSite&idSite=124&siteName=foo&urls=http%3A%2F%2Fwhatever.com
This makes no sense - and can't IMHO not be deserved, as delteSite returns
{"result":"error", "message":"website id = 124 not found"}
on error.
Thanks for your work! Steffen
The text was updated successfully, but these errors were encountered:
Attachment: Patch file 1585.diff
Sorry, something went wrong.
To may be speed it up a bit and make your life easier :) I've attached a patch, which adds the same check, which is also done in deleteSite()
Thanks, but getAllSitesId() requires superuser access. Some refactoring needs to be done.
(In [2928]) fixes #1585
(In [2977]) refs #1585, refs #1638 - merged from trunk
No branches or pull requests
The response for SitesManager.updateSite is wrong. Calling it with an unknown idSite parameter results in
http://example.com/?module=API&idSite=124&format=JSON&token_auth=YOUR_TOKEN&method=SitesManager.updateSite&idSite=124&siteName=foo&urls=http%3A%2F%2Fwhatever.com
This makes no sense - and can't IMHO not be deserved, as delteSite returns
on error.
Thanks for your work!
Steffen
The text was updated successfully, but these errors were encountered: