Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action datatables should use integer indexes rather than string indexes (smaller size and faster access) #1600

Closed
mattab opened this issue Aug 16, 2010 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Aug 16, 2010

Currently datatables for Actions are indexed with the metrics string (nb_visits, nb_hits, etc.). See code in plugins/Actions/Actions.php archiveDay()

Other datatables are using integer indexes, mapping is defined in Piwik_Archive::$mappingFromIdToName

Actions datatable should use a similar integer mapping to reduce size of Actions datatables, and make querying faster.

@mattab
Copy link
Member Author

mattab commented Jan 8, 2011

thanks to halfdan run of xhprof, we now know that this is indeed very costly, lets fix it

@mattab
Copy link
Member Author

mattab commented Jan 11, 2011

(In [3696]) Page titles report improvements fixes #1898

  • new fields in 2 log tables (major schema upgrade in next release!)
  • code refactored and optimized,
    (only the UI to display top entry/exit page titles is missing)

Performance improvements

Improvements to integration tests

  • never loads the Provider plugin in proxy-piwik.php since reverse ip lookup slows up tests a lot
  • fixing a test result that were previously incorrect (_withCookieSupport) because a static cache wasn't cleaned after each test

@mattab mattab added this to the Piwik 1.2 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

1 participant