New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS3 Support for IE 8 with CSS3PIE #1625
Comments
There's diminishing value with IE9 approaching, but if CSS3PIE is compatible with jQuery/jQueryUI, and isn't noticeably slower for IE8 users, then it's fine with me. |
As there are many big companies still using older browsers like IE7, we should try to optimize the layout for IE. As CSS3PIE works for IE 6,7 & 8 it might be a good choice. I already tried to integrate it and it seems to be quite easy. |
Assign the ticket so others know it's being worked on. WRT browser support. Piwik supports older browsers (e.g., IE5 and above) in piwik.js, but for the dashboard/GUI, we only want to support newer releases otherwise the cross-browser regression testing (and maintenance for backward compatibility) becomes too burdensome. We also have to consider constraints by third-party libs (e.g., jQuery). |
CSS3PIE has a dual license: Apache-2 and/or GPL-2 (see http://github.com/lojjic/PIE/blob/master/LICENSE) Are those licenses compatible with ours? |
Fortunately, Apache 2 is compatible with GPL v3. If it was dual licensed as Apache 2 or GPL (v2 or later), either would be fine. |
Ok, fine. I will try to finish a first integration this weekend. If it works stable, I will commit it to trunk, so that others can test it before merging it to the 1.0 branch. |
(In [3017]) refs #1625 added CSS3PIE to libs |
(In [3018]) fixes #1625 added use of css3pie for ie |
(In [3019]) refs #1625 - update legal notice |
(In [3020]) refs #1625 do not use css3pie for '.entityTable' - seems to crash IE |
I tried trunk in IE8 but I don't see rounded corners (calendar, website selector etc.) is it expected? |
I'll fix that ... libs/CSS3PIE/PIE.php (a php proxy to server PIE.htc) is probably blocked by libs/.htaccess. |
Reference: http://css3pie.com/documentation/known-issues/ Is this why rounded corners only appears when the AssetManager is enabled? |
With ./libs/CSS3PIE/PIE.php, CSS3PIE works with AssetManager enabled and disabled. I've been looking for a fix but I'm not even able to make it work like it used to, ie. with AssetManager enabled and using:
I tried several ways to declare the file : ./index.php, /index.php, index.php, ../../index.php I looked at any modifications made to Piwik::serveStaticFile() and couldn't find anything that would help me understand. |
Strange indeed. I'll reopen for investigation. |
(In [3157]) fixes #1625 - tested with assetmanger enabled and disabled |
Sorry, there are some unrelated changes in that commit. I tried to Ctrl-C that but was too late to abort the commit. |
[3158] reverts the last set of changes |
(In [3159]) refs #1625 - marking as fix; anomalies appear to be an internal cache issue with IE |
I am using IE8, but I don't see any UI changes (rounded corners, etc.) after the changes in this ticket. Do you see any changes in IE8? |
This would be the cache "anomaly". Clearing the browser cache and restarting the browser helps. Make sure IE isn't in compatibility mode. |
Cool, after fixing #1822 I now see the rounded corners in IE. |
I just tried on the demo.piwik.org, with IE8, and I see a Javascript error message in PieHtc:
To replicate, go to dashboard, Add a widget, and hover over the items |
(In [3915]) refs #1625 - update to CSS3PIE 1.0beta3 |
It looks like it fixed it, no more errors in IE. thanks vipsoft! |
I just found the CSS3PIE project, which aims to add CSS3 support to Internet Explorer 8 (and below). I tried this demo in IE8 and it works (rounded corners, css shadow).
Maybe we can integrate this into Piwik.
The text was updated successfully, but these errors were encountered: