New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged javascript files: preserve licence and copyright in merged file #1640
Comments
Reference: http://www.gnu.org/philosophy/javascript-trap.html Stallman suggests the following notice where JavaScript is embedded in a page:
|
The merged javascript file contains third party javascript libraries. From a license compatibility point of view, would it be ok to add this notice at the beginning of the merged file ? |
I would leave the license headers at the beginning of each minified file because that's how it appears now with pre-minified files that are simply included (e.g., jquery.js and jquery-ui.js). It should be as simple as updating JSMin.php and making sure the comment headers in each JavaScript file consistently uses /*! ... */ so that it is preserved in the minified output. p.s. ignore comment:2. |
I am not confident with 'updating JSMin.php' and vote for a wontfix. The important thing is that we take licenses seriously and any Piwik user is able to find out the licenses of the libraries we use by looking at the well maintained file: https://github.com/piwik/piwik/blob/master/LEGALNOTICE Most Open Source projects don't have such a file, so this is already a great effort to make visible the libraries we use and their licenses. won't fix |
A couple of points:
|
jsmin is deprecated, cf : https://github.com/rgrove/jsmin-php/ : This project is unmaintained. I stopped using it years ago. You shouldn't use it. You shouldn't use any version of JSMin. I found https://github.com/tedivm/JShrink as a replacement and will remove jsmin while fixing #4373. JShrink preserves licenses. |
It's debateable whether or not this is necessary when minifying on-the-fly...
reference: http://code.google.com/p/minify/source/browse/branches/2.1.4/min/lib/JSMin.php
Keywords: interesting
The text was updated successfully, but these errors were encountered: